Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tb_print* functions a little kinder #77

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Make tb_print* functions a little kinder #77

merged 1 commit into from
Sep 3, 2024
+103 −13

Conversation

adsr
Copy link
Contributor

@adsr adsr commented Jul 27, 2024 •
edited
Loading

Make the follow changes to tb_print*:

  • Handle newlines. Previously newlines would mess up rendering.
  • Replace other non-printable codepoints with U+FFFD. Previously tabs, control chars, escape codes, etc would mess up rendering.
  • As long as the print starts in bounds, then skip over cells that would go out of bounds instead returning an error. These are convenience functions, so it makes sense to me to be more lenient.

See also #76

@adsr
make tb_print* functions a little kinder
4d94158 
* handle newlines. previously they would mess up rendering.
* replace other non-printable codepoints with U+FFFD.
* skip over cells that would go out of bounds instead of erroring.
@adsr adsr force-pushed the tb_print_newline branch from d25ed5b to 4d94158 Compare July 27, 2024 21:13
@adsr adsr mentioned this pull request Jul 28, 2024
Merged
@adsr
Copy link
Contributor Author

adsr commented Aug 4, 2024

Tagging some people for code reviewing this and #76.

@rofl0r @git-bruh @mitchellwrosen

@adsr adsr merged commit b075ddd into master Sep 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adsr