Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all styles to Internal.Junk.hoverAt #58

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Add all styles to Internal.Junk.hoverAt #58

merged 1 commit into from
Jul 24, 2019

Conversation

TSFoster
Copy link
Contributor

Not all styles were being included in the div returned from Internal.Junk.hoverAt (also fixes a typo in the function). Fixes #55.

@TSFoster
Copy link
Contributor Author

Also fixes #59

@yuzisee
Copy link

yuzisee commented Jan 1, 2019

This fixes hoverAt as well as hover, hoverOne and hoverMany because they all rely on hoverAt

@yuzisee yuzisee mentioned this pull request Jan 1, 2019
Open
@Munksgaard Munksgaard mentioned this pull request Feb 1, 2019
Closed
@runeksvendsen runeksvendsen mentioned this pull request Jul 13, 2019
Closed
@runeksvendsen
Copy link

@terezka could you merge this please? I just ran into #59 and I can confirm that this PR fixes it.

@terezka terezka merged commit 3bd68d8 into terezka:master Jul 24, 2019
@diogob
Copy link

diogob commented Aug 2, 2019

thanks for the fixes @TSFoster and thanks for the library @terezka
Could we have them released to elm packages?
For future reference there is a forked package with the fix included: peterszerzo/line-charts

@LiberalArtist LiberalArtist mentioned this pull request Aug 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Junk.hoveryMany doesn't work for more than 310 points
5 participants
@TSFoster @yuzisee @runeksvendsen @diogob @terezka