-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mount): pass attributes
directly to component
#48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This will remove the `attr` made available when using `view` and `mounted`. Instead you can use `el.dataset` and type your expected incoming data-* attributes with `Component<{}, Attrs>` and define those in `Attrs`.
When looping use `for` loops instead, which _should_ be slightly faster. Right?
All next tags will be released on the regular release workflow.
sebkolind
added
☀️ enhancement
New feature or request
🧪 experimental
Things might explode
labels
Jun 4, 2024
hyber1z0r
reviewed
Jun 4, 2024
hyber1z0r
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal that allows passing
attributes
directly to a component via themount
function. It is useful for passing data to the component, that is available immediately on mount. Below is an example usage, where the parent component opens a modal at the click of a button.The use case could also be if you fetch data from an endpoint in another component, and mounts a component with data from the response.
Usage