Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Component): require state if S is defined #45

Merged
merged 3 commits into from
Jun 2, 2024

Conversation

sebkolind
Copy link
Collaborator

@sebkolind sebkolind commented Jun 2, 2024

If defining state in the Component<S> generic, state will now be required when defining the component, and it will give a type error if not set.

Fixes TEN-13
Closes #43

@sebkolind sebkolind added 🐛 bug Something isn't working ☀️ enhancement New feature or request labels Jun 2, 2024
@sebkolind sebkolind self-assigned this Jun 2, 2024
@sebkolind sebkolind removed the ☀️ enhancement New feature or request label Jun 2, 2024
@sebkolind sebkolind changed the base branch from main to next June 2, 2024 10:30
@sebkolind sebkolind linked an issue Jun 2, 2024 that may be closed by this pull request
@sebkolind sebkolind force-pushed the fix/require-state-on-component branch from 7e96445 to cc8159e Compare June 2, 2024 10:34
@sebkolind sebkolind merged commit d7e273a into next Jun 2, 2024
1 check passed
@sebkolind sebkolind deleted the fix/require-state-on-component branch June 2, 2024 10:43
sebkolind added a commit that referenced this pull request Jun 2, 2024
sebkolind added a commit that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require setting state if given to the Component generic
1 participant