Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: iOS Duplicate Symbols Between MLImage and Vision Task Library #892

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Bug Fix: iOS Duplicate Symbols Between MLImage and Vision Task Library #892

wants to merge 5 commits into from

Conversation

priankakariatyml
Copy link
Contributor

No description provided.

@priankakariatyml
Copy link
Contributor Author

@khanhlvg @lu-wang-g @schmidt-sebastian Raised a PR for fixing the duplicate symbols error between MLImage and Vision Task Library

@khanhlvg
Copy link
Member

I discussed with Prianka about this yesterday.

Fundamentally we'll need to depend on MLImage pod rather than bundle MLImage inside TFLiteTaskVision. It'll require us to release a new version of TFLiteTaskVision every time a new version of MLImage is released and newer version of MLKit depends on it. We need to come up with a strategy for that before working on making TFLiteTaskVision to depend on MLImage.

@schmidt-sebastian
Copy link
Collaborator

Thanks for the insight.

schmidt-sebastian
schmidt-sebastian requested changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to figure out how to proceed here.

@ewfian
Copy link

ewfian commented Feb 22, 2023

related: #885

1 similar comment
@nysamnang
Copy link

related: #885

@abdelrahman-muntaser
Copy link

Is this gonna work if i used the library from this pull request until they merged it ?

@Karllas
Copy link

Karllas commented Jan 29, 2024

When will this be merged? We cannot use GoogleMLKit and TensorFlowLiteTaskVision together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@priankakariatyml @khanhlvg @schmidt-sebastian @ewfian @nysamnang @abdelrahman-muntaser @Karllas