Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

Removing reliance on experimental TF_GetServerDef TensorFlow api #976

Merged
merged 2 commits into from
May 30, 2020
Merged

Removing reliance on experimental TF_GetServerDef TensorFlow api #976

merged 2 commits into from
May 30, 2020

Conversation

ematejska
Copy link
Contributor

Removing reliance on experimental TF_GetServerDef TensorFlow api.

This will unblock: #957
Part of: #970

@ematejska ematejska requested review from pschuh and asuhan May 29, 2020 04:04
@ematejska
Copy link
Contributor Author

Any tips on how to properly test this are appreciated.

asuhan
asuhan approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@asuhan asuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need more extensive tests @pschuh ? ops_test should cover both x10 and eager backends properly.

@ematejska
Copy link
Contributor Author

@compnerd How do I test Windows?

@ematejska ematejska merged commit fa373f3 into tensorflow:master May 30, 2020
@ematejska ematejska mentioned this pull request May 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asuhan asuhan asuhan approved these changes

@pschuh pschuh Awaiting requested review from pschuh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ematejska @asuhan @kokoro-team