Rename overview page in OSS

PiperOrigin-RevId: 627008419

frontend/app/common/interfaces/data_table.ts

@@ -317,12 +317,12 @@ export type MemoryProfileSnapshot = memoryProfileProto.MemoryProfileSnapshot;
 export type OpProfileProto = opProfileProto.Profile;
 
 /** All overview page data table type. */
-export type OverviewDataTable =
+export type OverviewPageDataTable =
     GeneralAnalysis|InputPipelineAnalysis|RecommendationResult|RunEnvironment|
     SimpleDataTable|NormalizedAcceleratorPerformance;
 
 /** All overview page data tuple type. */
-export type OverviewDataTuple = [
+export type OverviewPageDataTuple = [
   GeneralAnalysis,
   InputPipelineAnalysis,
   RunEnvironment,
@@ -373,7 +373,7 @@ export type PrimitiveTypeNumberStringOrUndefined = number|string|undefined;
 
 /** All data type from tool response data. */
 export type DataTable =
-    SimpleDataTable|OverviewDataTable[]|InputPipelineDataTable[]|
+    SimpleDataTable|OverviewPageDataTable[]|InputPipelineDataTable[]|
     FrameworkOpStatsData[]|HloProto|MemoryViewerPreprocessResult|
     MemoryProfileProto|OpProfileProto|PodViewerDatabase;
 

frontend/app/components/main_page/BUILD

@@ -34,7 +34,7 @@ xprof_ng_module(
         "@org_xprof//frontend/app/components/memory_profile",
         "@org_xprof//frontend/app/components/memory_viewer",
         "@org_xprof//frontend/app/components/op_profile",
-        "@org_xprof//frontend/app/components/overview",
+        "@org_xprof//frontend/app/components/overview_page",
         "@org_xprof//frontend/app/components/pod_viewer",
         "@org_xprof//frontend/app/components/sidenav",
         "@org_xprof//frontend/app/components/tf_data_bottleneck_analysis",

frontend/app/components/main_page/main_page_module.ts

@@ -21,8 +21,8 @@ import {MemoryViewer} from 'org_xprof/frontend/app/components/memory_viewer/memo
 import {MemoryViewerModule} from 'org_xprof/frontend/app/components/memory_viewer/memory_viewer_module';
 import {OpProfile} from 'org_xprof/frontend/app/components/op_profile/op_profile';
 import {OpProfileModule} from 'org_xprof/frontend/app/components/op_profile/op_profile_module';
-import {Overview} from 'org_xprof/frontend/app/components/overview/overview';
-import {OverviewModule} from 'org_xprof/frontend/app/components/overview/overview_module';
+import {OverviewPage} from 'org_xprof/frontend/app/components/overview_page/overview_page';
+import {OverviewPageModule} from 'org_xprof/frontend/app/components/overview_page/overview_page_module';
 import {PodViewer} from 'org_xprof/frontend/app/components/pod_viewer/pod_viewer';
 import {PodViewerModule} from 'org_xprof/frontend/app/components/pod_viewer/pod_viewer_module';
 import {SideNavModule} from 'org_xprof/frontend/app/components/sidenav/sidenav_module';
@@ -36,9 +36,9 @@ import {MainPage} from './main_page';
 /** The list of all routes available in the application. */
 export const routes: Routes = [
   {path: 'empty', component: EmptyPage},
-  {path: 'overview_page', component: Overview},
-  {path: 'overview_page@', component: Overview},
-  {path: 'overview_page^', component: Overview},
+  {path: 'overview_page', component: OverviewPage},
+  {path: 'overview_page@', component: OverviewPage},
+  {path: 'overview_page^', component: OverviewPage},
   {path: 'input_pipeline_analyzer', component: InputPipeline},
   {path: 'input_pipeline_analyzer@', component: InputPipeline},
   {path: 'input_pipeline_analyzer^', component: InputPipeline},
@@ -76,7 +76,7 @@ export const routes: Routes = [
     EmptyPageModule,
     SideNavModule,
     TraceViewerModule,
-    OverviewModule,
+    OverviewPageModule,
     InputPipelineModule,
     KernelStatsAdapterModule,
     MemoryProfileModule,

frontend/app/components/overview/BUILD → frontend/app/components/overview_page/BUILD

@@ -4,15 +4,15 @@ load("//defs:defs.bzl", "xprof_ng_module")
 package(default_visibility = ["//frontend:internal"])
 
 xprof_ng_module(
-    name = "overview",
+    name = "overview_page",
     srcs = [
-        "overview.ts",
-        "overview_common.ts",
-        "overview_module.ts",
+        "overview_page.ts",
+        "overview_page_common.ts",
+        "overview_page_module.ts",
     ],
     assets = [
-        ":overview_css",
-        "overview.ng.html",
+        ":overview_page_css",
+        "overview_page.ng.html",
     ],
     deps = [
         "@npm//@angular/common",
@@ -24,20 +24,20 @@ xprof_ng_module(
         "@org_xprof//frontend/app/common/interfaces",
         "@org_xprof//frontend/app/common/utils",
         "@org_xprof//frontend/app/components/diagnostics_view",
-        "@org_xprof//frontend/app/components/overview/normalized_accelerator_performance_view",
-        "@org_xprof//frontend/app/components/overview/performance_summary",
-        "@org_xprof//frontend/app/components/overview/recommendation_result_view",
-        "@org_xprof//frontend/app/components/overview/run_environment_view",
-        "@org_xprof//frontend/app/components/overview/step_time_graph",
-        "@org_xprof//frontend/app/components/overview/top_ops_table",
+        "@org_xprof//frontend/app/components/overview_page/normalized_accelerator_performance_view",
+        "@org_xprof//frontend/app/components/overview_page/performance_summary",
+        "@org_xprof//frontend/app/components/overview_page/recommendation_result_view",
+        "@org_xprof//frontend/app/components/overview_page/run_environment_view",
+        "@org_xprof//frontend/app/components/overview_page/step_time_graph",
+        "@org_xprof//frontend/app/components/overview_page/top_ops_table",
         "@org_xprof//frontend/app/services/data_service",
         "@org_xprof//frontend/app/store",
     ],
 )
 
 sass_binary(
-    name = "overview_css",
-    src = "overview.scss",
+    name = "overview_page_css",
+    src = "overview_page.scss",
     sourcemap = False,
     deps = [
         "@org_xprof//frontend/app/styles:common",

frontend/app/components/overview/overview.ts → frontend/app/components/overview_page/overview_page.ts

@@ -1,22 +1,22 @@
 import {Component, OnDestroy} from '@angular/core';
 import {ActivatedRoute} from '@angular/router';
 import {Store} from '@ngrx/store';
-import {OverviewDataTuple, RunEnvironmentProperty} from 'org_xprof/frontend/app/common/interfaces/data_table';
+import {OverviewPageDataTuple, RunEnvironmentProperty} from 'org_xprof/frontend/app/common/interfaces/data_table';
 import {NavigationEvent} from 'org_xprof/frontend/app/common/interfaces/navigation_event';
 import {DataService} from 'org_xprof/frontend/app/services/data_service/data_service';
 import {setLoadingStateAction} from 'org_xprof/frontend/app/store/actions';
 import {ReplaySubject} from 'rxjs';
 import {takeUntil} from 'rxjs/operators';
 
-import {OverviewCommon} from './overview_common';
+import {OverviewPageCommon} from './overview_page_common';
 
 /** An overview page component. */
 @Component({
-  selector: 'overview',
-  templateUrl: './overview.ng.html',
-  styleUrls: ['./overview.css']
+  selector: 'overview_page',
+  templateUrl: './overview_page.ng.html',
+  styleUrls: ['./overview_page.css']
 })
-export class Overview extends OverviewCommon implements OnDestroy {
+export class OverviewPage extends OverviewPageCommon implements OnDestroy {
   /** Handles on-destroy Subject, used to unsubscribe. */
   private readonly destroyed = new ReplaySubject<void>(1);
 
@@ -53,8 +53,8 @@ export class Overview extends OverviewCommon implements OnDestroy {
             }
           }));
 
-          /** Transfer data to Overview DataTable type */
-          this.parseOverviewData((data || []) as OverviewDataTuple);
+          /** Transfer data to Overview Page DataTable type */
+          this.parseOverviewPageData((data || []) as OverviewPageDataTuple);
           this.parseRunEnvironmentDetail();
         });
   }

frontend/app/components/overview/overview_common.ts → frontend/app/components/overview_page/overview_page_common.ts

@@ -1,4 +1,4 @@
-import {GeneralAnalysis, InputPipelineAnalysis, NormalizedAcceleratorPerformance, OverviewDataTuple, RecommendationResult, RunEnvironment} from 'org_xprof/frontend/app/common/interfaces/data_table';
+import {GeneralAnalysis, InputPipelineAnalysis, NormalizedAcceleratorPerformance, OverviewPageDataTuple, RecommendationResult, RunEnvironment} from 'org_xprof/frontend/app/common/interfaces/data_table';
 import {Diagnostics} from 'org_xprof/frontend/app/common/interfaces/diagnostics';
 import {parseDiagnosticsDataTable} from 'org_xprof/frontend/app/common/utils/utils';
 
@@ -10,7 +10,7 @@ const NORMALIZED_ACCELERATOR_PERFORMANCE_INDEX = 5;
 const DIAGNOSTICS_INDEX = 6;
 
 /** A common class of overview page component. */
-export class OverviewCommon {
+export class OverviewPageCommon {
   private propertyValues: string[] = [];
 
   diagnostics: Diagnostics = {info: [], warnings: [], errors: []};
@@ -29,7 +29,7 @@ export class OverviewCommon {
     this.propertyValues = propertyValues;
   }
 
-  parseOverviewData(data: OverviewDataTuple) {
+  parseOverviewPageData(data: OverviewPageDataTuple) {
     this.generalAnalysis = data[GENERAL_ANALYSIS_INDEX];
     this.inputPipelineAnalysis = data[INPUT_PIPELINE_ANALYSIS_INDEX];
     this.runEnvironment = data[RUN_ENVIRONMENT_INDEX];

frontend/app/components/overview/overview_module.ts → frontend/app/components/overview_page/overview_page_module.ts

@@ -1,18 +1,18 @@
 import {CommonModule} from '@angular/common';
 import {NgModule} from '@angular/core';
 import {DiagnosticsViewModule} from 'org_xprof/frontend/app/components/diagnostics_view/diagnostics_view_module';
-import {NormalizedAcceleratorPerformanceViewModule} from 'org_xprof/frontend/app/components/overview/normalized_accelerator_performance_view/normalized_accelerator_performance_view_module';
-import {PerformanceSummaryModule} from 'org_xprof/frontend/app/components/overview/performance_summary/performance_summary_module';
-import {RecommendationResultViewModule} from 'org_xprof/frontend/app/components/overview/recommendation_result_view/recommendation_result_view_module';
-import {RunEnvironmentViewModule} from 'org_xprof/frontend/app/components/overview/run_environment_view/run_environment_view_module';
-import {StepTimeGraphModule} from 'org_xprof/frontend/app/components/overview/step_time_graph/step_time_graph_module';
-import {TopOpsTableModule} from 'org_xprof/frontend/app/components/overview/top_ops_table/top_ops_table_module';
+import {NormalizedAcceleratorPerformanceViewModule} from 'org_xprof/frontend/app/components/overview_page/normalized_accelerator_performance_view/normalized_accelerator_performance_view_module';
+import {PerformanceSummaryModule} from 'org_xprof/frontend/app/components/overview_page/performance_summary/performance_summary_module';
+import {RecommendationResultViewModule} from 'org_xprof/frontend/app/components/overview_page/recommendation_result_view/recommendation_result_view_module';
+import {RunEnvironmentViewModule} from 'org_xprof/frontend/app/components/overview_page/run_environment_view/run_environment_view_module';
+import {StepTimeGraphModule} from 'org_xprof/frontend/app/components/overview_page/step_time_graph/step_time_graph_module';
+import {TopOpsTableModule} from 'org_xprof/frontend/app/components/overview_page/top_ops_table/top_ops_table_module';
 
-import {Overview} from './overview';
+import {OverviewPage} from './overview_page';
 
 /** An overview page module. */
 @NgModule({
-  declarations: [Overview],
+  declarations: [OverviewPage],
   imports: [
     CommonModule,
     DiagnosticsViewModule,
@@ -23,7 +23,7 @@ import {Overview} from './overview';
     TopOpsTableModule,
     NormalizedAcceleratorPerformanceViewModule,
   ],
-  exports: [Overview]
+  exports: [OverviewPage]
 })
-export class OverviewModule {
+export class OverviewPageModule {
 }