Skip to content

Commit

Permalink
Rename "TF Op" labels to "Framework Op" in most cases for generality
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 613776363
  • Loading branch information
zzzaries authored and copybara-github committed Mar 8, 2024
1 parent b2c1188 commit 31ff6ad
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
<div>
<div class="mat-headline">Framework Operations</div>
<mat-form-field>
<mat-label>Host/device</mat-label>
<mat-label>Host/Device</mat-label>
<input
matInput
[value]="filterExecutor"
(change)="filterExecutor = $event.target.value; updateFilters();">
<mat-icon matSuffix>search</mat-icon>
</mat-form-field>
<mat-form-field>
<mat-label>Type</mat-label>
<mat-label>Operation Type</mat-label>
<input
matInput
[value]="filterType"
(change)="filterType = $event.target.value; updateFilters();">
<mat-icon matSuffix>search</mat-icon>
</mat-form-field>
<mat-form-field>
<mat-label>Operation</mat-label>
<mat-label>Operation Name</mat-label>
<input
matInput
[value]="filterOperation"
Expand Down
4 changes: 2 additions & 2 deletions frontend/app/components/op_profile/op_table/op_table.ng.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<span class="time-header" matTooltip="Total percentage of the time spent by all the operations in that xla module or category.">Time %</span>
<span class="wasted-header" matTooltip="Wasted time is defined by RuntimeFraction *(1 - max(FlopsUtilization, MemoryBandwidthUtilization)).">Wasted %</span>
<span class="hbmFraction-header" matTooltip="HBM fraction is the raw hbm bytes accessed percentage of the xla module or category.">HBM %</span>
<span class="name-header" matTooltip="Name of the xla module, op category, or ops.">Name</span>
<span class="provenance-header" matTooltip="TensorFlow op name associated with the HLO operation.">TensorFlow Op</span>
<span class="name-header" matTooltip="Name of the xla module, op category, or ops.">HLO Op Name</span>
<span class="provenance-header" matTooltip="Framework op type associated with the HLO operation.">Framework Op type</span>
<span class="utilization-header" matTooltip="FLOPS bandwidth utilization normalized to the xla module or category scale.">FLOPS</span>
<span class="flame-color-circle-header"></span>
<span class="hbmUtilization-header" matTooltip="HBM memory bandwidth utilization.">HBM</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ const GENERIC_SUMMARY_INFO_BEFORE: SummaryInfoConfig[] = [
/** Generic summary info, display on bottom of the list */
const GENERIC_SUMMARY_INFO_AFTER: SummaryInfoConfig[] = [
{
title: 'TF Op Placement',
tooltip: 'Ratio of TF Ops executed on the host and device.',
title: 'Framework Op Placement',
tooltip: 'Ratio of Framework Ops executed on the host and device.',
description: 'generally desired to have more ops on device',
childrenInfoConfig: [
{title: 'Host', valueKey: 'host_tf_op_percent'},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class TopOpsTable implements AfterViewInit, OnChanges {

this.inputPipelineAnalysis.p = this.inputPipelineAnalysis.p || {};
this.title = 'Top ' + String(dataTable.getNumberOfRows()) +
' TensorFlow operations on ' +
' Framework Operations on ' +
(this.inputPipelineAnalysis.p['hardware_type'] || 'TPU');

const columns: TopOpsColumn = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ def test_device_trace_contains_threads(self):
process_names.append((event['args']['name']))
self.assertContainsSubset(
[
'TensorFlow Name Scope',
'TensorFlow Ops',
'Framework Name Scope',
'Framework Ops',
'XLA Modules',
'XLA Ops',
'XLA TraceMe',
Expand Down

0 comments on commit 31ff6ad

Please sign in to comment.