-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark Mode support Added #147
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This looks pretty good. I just noticed that the text in the drop-down selection and the text next to the checkboxes is not visible in the dark mode. |
@UnlimitedCookies the text may not be visible in the gif but I will try to improve that. |
That might be the case. Then there's not much to do.
…On Fri, Feb 26, 2021, 20:09 Abhijay Jain ***@***.***> wrote:
This looks pretty good. I just noticed that the text in the drop-down
selection and the text next to the checkboxes is not visible in the dark
mode.
@UnlimitedCookies <https://github.com/UnlimitedCookies> the text may be
not visible in the gif but I will try to improve that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#147 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALXLYWF6H5NXIC5ZUYBYQ43TA7WWVANCNFSM4VBNLRHQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Dark Mode support Added (feature implemented)
Here is the video in gif format, of the implemented feature: