-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature linux support #162
Conversation
I don't currently have a Linux machine, but I can set one up to test it. @CaptainDario Could you help me resolve the conflict? |
Yeah, sure! Do you encounter the same issue as PaulTR? |
@PaulTR I think I found the problem that you were encountering and I pushed a fix. @st-duymai Let me know if you have problems setting this up. |
Sounds good, I'll see if I can make my way in to an office tomorrow or Wednesday to give it one more shot. Thanks! |
@CaptainDario I frequently encounter this problem when building Linux applications. Have you ever dealt with this issue before? |
No I have not seen this issue, how did you build the binary? The one I used can be found here |
Thanks @CaptainDario I will check again with your .so library. I may have built it wrong at some step. |
Hi @PaulTR , After check with .so library that @CaptainDario provide above, I can confirm that the following five examples are working properly:
However, two examples are not working:
|
Hi @CaptainDario
|
You forgot to checkout a specific release, I guess the state you are currently in is broken. I used r2.12 |
Awesome, thanks for checking on those. Yeah those two are expected to not work with desktop, so that's fine. I think once we have those conflicts resolved we should be pretty golden then for all three desktop versions! :) |
Hi @CaptainDario Would you mind resolving the conflict in this PR? Thank you. |
Yeah sure! I did not notice that there are conflicts. |
done |
Hi @CaptainDario . I think this PR look greate and ready to merge. I just have one minor request regarding the readme file, which I mentioned earlier. Thank you for your hard work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
@st-duymai are you able to release new tf lite version on pub? |
Sorry. I don't have any information about that. |
@PaulTR, when you have some time, could you take a look at releasing a new version at pub? |
@CaptainDario The new version was published a few days ago (tflite_flutter: ^0.10.4). Please check. |
@st-duymai thanks for the heads up, I tried it! |
This PR should add linux support.
Environment:
Changes:
Notes:
Progress: