Merge Master array algebra into Master #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w propagation of indexVar type to generated code
…ler/taco into array_algebra
…omputing with IndexVars when using split command. Started implementing boilerplate code for iteration space algebra
…r tensorOp nodes.
…so users can create vectors of properties which are actually a vector of pointers. This is a work around to avoid object slicing when storing properties in a vector
…ith lowering generic tensorOp. Changed spec of special definition to take an IR function.
…ttice optimizations to the end of lattice construction. Conditions to apply these optimizations still not quite right so all tests pass for now. Need to also check that no producer regions have a special definition. Lowerer also needs to be altered to handle compute regions more generally instead of just sparse. Lowerer needs to be altered to handle explicit zeros.
…ice in lowerer. Added explicit zero checks in bottom loop of compute
…ing explicit zero checks before bottommost loop. Got Masked BFS optimization working for pull bfs!
…ue inferer that only uses properties.
…sparsifying a dense result using tensor ops
…tice construction introduce in the merge. Seems to always include the dimension iterator in the merge points even when the iterators are sparse
…orVar was merged incorrectly so all formats were dense inside the lattice
…the GPU backend to be completely non-functional
… an expression. Also, prevents generation of unnecessary merge loops being created at some loop levels
Array algebra index set bugs
lowerer: small patch to make taco values array allocation sized better
index_notation: small hack for hitting the compile cache in certain cases
index_notation: hack to stop removal of reductions with ufuncs
… master_array_algebra
This reverts commit 4c845e3.
lowerer_impl: fix some striding bugs Fixes some formulaic errors in generated striding code along with a test that revealed them. WIP trying to fix lattice construction Add in some changes to iteration lattice construction Add in locator check as well Add in iteration lattice construction changes for intersectLattices() as well Fix iteration lattice comparison (to sort points first) and check for empty points when unionLattices and intersectLattices are called
…tors.h to correct include/ dir
|
I gave the PR a scan, it seems fine to me (i.e. nothing stands out as openly breaking much). |
rohany
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #504
all regressions are passing but I think we need to make sure that the website kernels aren't broken?