Cmake changes #481
Closed
Cmake changes #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the openmp find module allows cflags etc to be managed by cmake. Conditional linking/target specific compile defintions allow for a tidier and more explicit behavior. Associating all such behavior with the targets can also make it easier to expose the appropriate settings for downstream projects via the PUBLIC keyword.
setting include_dirs on targets instead of setting them for the project or directory level encapsulates within project dependencies a little more cleanly and facilitates exporting targets for downstreams with the appropriate include directories set
uses target_include_dirs to explicitly define the directories used for the taco library. add alias taco::taco so that downsteams can link against the library whether installed or incorporated into a fetchcontent pattern.
|
Sorry! This was supposed to be a PR elsewhere and not in the TACO repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.