Fix some precompute transformation algorithm bugs that arose #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the algorithm so that the precompute transformation can only occur on cascaded
ForallNodes
without anyWhereNodes
inside theforall->stmt
. The current testDISABLED_tile_dotProduct_1
tests this case but is currently disabled because of the issue stated in the test's comments/FIXME.Also fix a minor bug where
expected
andA
were flipped intest/tests-workspaces.cpp
when callingASSERT_TENSOR_EQ(expected, A)
.Also added in some disabled precompute tests that should work but currently do not due to certain new bugs found in the algorithm. I would like to add these tests in to the regression disabled and track re-enabling them using Git issues.