-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multidimensional dense workspaces #475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute(...) and fix multi-dimensional lowering
…mensional ws indexvars
stephenchouca
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precompute(...)
concrete index notation transformation algorithm to be similar to the one in the TACO workspaces paper.ir::Stmt
workspace_rewriter
to allow for multi-dimensional dense workspace lowering. This rewriter rewrites the loweredir::Stmt
to replace all workspaceGetProperty(..., Dimension)
nodes with the correctir::Expr
corresponding to the workspace size for that mode.test/tests-workspaces.cpp
This does not break any of the GPU tests (see https://github.com/tensor-compiler/taco/actions/runs/955323370)
Note: Some
*Scheduled(...)
(likeconcretizeScheduled()
,isReductionNotationScheduled()
, etc.) methods insrc/index_notation/index_notation.cpp
are not currently being used but should be useful in the future. They were originally created for another version of theprecompute(...)
transformation algorithm, but are no longer needed there. I would still like to add them in tomaster
along with this PR since there are still scenarios where the compiler needs to concretize an Einsum notation assignment with a ProvenanceGraph into its corresponding post-scheduled concrete index notation statement.