[Time sensitive] Refactor lowerer_impl to be abstract with a lowerer_impl_C version #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also after this is done, I can add in a comment in the #taco channel on slack so that other people are aware about this change |
|
Also, can you make sure to run the GPU tests as well before merging to make sure there are no further regressions? |
|
@stephenchouca I can run the GPU tests, but no actual code has been changed in the lowerer other than the refactoring so it really shouldn't change any of the regression tests |
… lowerForall* functions from LowererImpl
|
@stephenchouca I ran the CUDA tests (here: https://github.com/tensor-compiler/taco/actions/runs/937343179) and no additional tests fail. Also resolved your reviewed changes above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can this be pulled in sooner rather than later since its based off of commit 2c2545d
This refactors LowererImpl to LowererImplC and implemented LowererImpl as an abstract class to allow for different imperative backends. This makes merging and updating master into the spatial branch easier as well since it follows the same hierarchical structure. It will also make merging the spatial branch into master easier in the future.