Missing index variable declarations for precompute #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests added and changes to fix the precompute indexVar |
weiya711
approved these changes
May 18, 2021
This was referenced May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues brought up in #431 and #347. Current behaviour of the precompute function generates incorrect code when
i != iw. This can be fixed by not adding the children of precompute relations to the provenance graph.Testing:
Added two test cases. First test case calls precompute with two different index variables. Second test case calls precompute with two different index variables before splitting the intermediary tensor to demonstrate that this fix does not impact subsequent transformations.