[improvement][chat] Optimize the MemoryReviewTask task by adding indi…

…vidual exception handling (#1788)
tencentmusic · Oct 11, 2024 · 72d01bb · 72d01bb
1 parent 0a86a63
commit 72d01bb
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 9 deletions.
diff --git a/chat/server/src/main/java/com/tencent/supersonic/chat/server/memory/MemoryReviewTask.java b/chat/server/src/main/java/com/tencent/supersonic/chat/server/memory/MemoryReviewTask.java
@@ -49,11 +49,14 @@ public class MemoryReviewTask {
 
     @Scheduled(fixedDelay = 60 * 1000)
     public void review() {
-        try {
-            memoryService.getMemoriesForLlmReview().stream().forEach(this::processMemory);
-        } catch (Exception e) {
-            log.error("Exception occurred during memory review task", e);
-        }
+        memoryService.getMemoriesForLlmReview().stream().forEach(memory -> {
+            try {
+                processMemory(memory);
+            } catch (Exception e) {
+                log.error("Exception occurred while processing memory with id {}: {}",
+                        memory.getId(), e.getMessage(), e);
+            }
+        });
     }
 
     private void processMemory(ChatMemoryDO m) {

diff --git a/...erver/src/main/java/com/tencent/supersonic/chat/server/service/impl/AgentServiceImpl.java b/...erver/src/main/java/com/tencent/supersonic/chat/server/service/impl/AgentServiceImpl.java
@@ -105,8 +105,7 @@ private void executeAgentExamplesAsync(Agent agent) {
     }
 
     private synchronized void doExecuteAgentExamples(Agent agent) {
-        if (!agent.containsDatasetTool()
-                || !agent.enableMemoryReview()
+        if (!agent.containsDatasetTool() || !agent.enableMemoryReview()
                 || !ModelConfigHelper.testConnection(
                         ModelConfigHelper.getChatModelConfig(agent, ChatModelType.TEXT_TO_SQL))
                 || CollectionUtils.isEmpty(agent.getExamples())) {

diff --git a/headless/api/src/main/java/com/tencent/supersonic/headless/api/pojo/ModelSchema.java b/headless/api/src/main/java/com/tencent/supersonic/headless/api/pojo/ModelSchema.java
@@ -1,8 +1,9 @@
 package com.tencent.supersonic.headless.api.pojo;
 
-import java.util.List;
 import lombok.Data;
 
+import java.util.List;
+
 @Data
 public class ModelSchema {
 

diff --git a/...ss/chat/src/main/java/com/tencent/supersonic/headless/chat/corrector/LLMSqlCorrector.java b/...ss/chat/src/main/java/com/tencent/supersonic/headless/chat/corrector/LLMSqlCorrector.java
@@ -56,7 +56,8 @@ public void doCorrect(ChatQueryContext chatQueryContext, SemanticParseInfo seman
             return;
         }
 
-        ChatLanguageModel chatLanguageModel = ModelProvider.getChatModel(chatQueryContext.getModelConfig());
+        ChatLanguageModel chatLanguageModel =
+                ModelProvider.getChatModel(chatQueryContext.getModelConfig());
         SemanticSqlExtractor extractor =
                 AiServices.create(SemanticSqlExtractor.class, chatLanguageModel);
         Prompt prompt = generatePrompt(chatQueryContext.getQueryText(), semanticParseInfo);