Skip to content

Commit

Permalink
fix existSegment bug which embedding search not has min-score,so that… (
Browse files Browse the repository at this point in the history
  • Loading branch information
JackLiang committed Jul 16, 2024
1 parent 13ae312 commit 35892f2
Showing 1 changed file with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,12 @@ private boolean existSegment(EmbeddingStore embeddingStore, TextSegment query, E
Map<String, String> filterCondition = new HashMap<>();
filterCondition.put(TextSegmentConvert.QUERY_ID, queryId);
Filter filter = createCombinedFilter(filterCondition);

EmbeddingSearchRequest request = EmbeddingSearchRequest.builder()
.queryEmbedding(embedding).filter(filter).maxResults(1).build();
.queryEmbedding(embedding).filter(filter).minScore(1.0d).maxResults(1).build();

EmbeddingSearchResult result = embeddingStore.search(request);
List<EmbeddingMatch<TextSegment>> relevant = result.matches();

boolean exists = CollectionUtils.isNotEmpty(relevant);

cache.put(queryId, exists);
return exists;
}
Expand Down Expand Up @@ -126,10 +123,8 @@ public List<RetrieveQueryResult> retrieveQuery(String collectionName, RetrieveQu
Filter filter = createCombinedFilter(filterCondition);
EmbeddingSearchRequest request = EmbeddingSearchRequest.builder()
.queryEmbedding(embeddedText).filter(filter).maxResults(num).build();

EmbeddingSearchResult result = embeddingStore.search(request);
List<EmbeddingMatch<TextSegment>> relevant = result.matches();

RetrieveQueryResult retrieveQueryResult = new RetrieveQueryResult();
retrieveQueryResult.setQuery(queryText);
List<Retrieval> retrievals = new ArrayList<>();
Expand All @@ -154,7 +149,6 @@ public List<RetrieveQueryResult> retrieveQuery(String collectionName, RetrieveQu
retrieveQueryResult.setRetrieval(retrievals);
results.add(retrieveQueryResult);
}

return results;
}

Expand Down

0 comments on commit 35892f2

Please sign in to comment.