Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Improve Linux support #50

Merged
merged 11 commits into from
Aug 24, 2022
Merged

Conversation

TheEvilSkeleton
Copy link
Collaborator

@TheEvilSkeleton TheEvilSkeleton commented Aug 16, 2022

Related to #21.

This MR does the following:

  • Use application ID instead of name for icons, appstream, desktop entry, and binary file.
  • Make the appstream file rename-friendly by using variables. When we'll change the name, it should be easy to do so.
  • Improve desktop entry

At the moment, I commented several parts of the metadata file, as we need to properly fill them up. We need proper screenshots to show that this is Saucedacity and not Audacity, and we need to change the rest of the metadata file to reflect the project itself.

  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"

@TheEvilSkeleton
Copy link
Collaborator Author

@generic-pers0n is it normal if macOS and Windows builds fail?

@generic-pers0n
Copy link
Member

@generic-pers0n is it normal if macOS and Windows builds fail?

Right now yes

@generic-pers0n
Copy link
Member

generic-pers0n commented Aug 17, 2022

Windows builds fail due to packaging issues with InnoSetup(?) because it can't find a language whereas macOS builds include extra files from Tenacity's libmad. Both I have to fix.

Update: Windows builds are now fixed. While they did technically "build" before, the issue was with Inno Setup packaging due to some language file not being found (or something; I don't know much about Inno Setup).

@generic-pers0n generic-pers0n mentioned this pull request Aug 20, 2022
4 tasks
@generic-pers0n generic-pers0n added the enhancement New feature or request label Aug 21, 2022
@TheEvilSkeleton TheEvilSkeleton changed the title Draft: Improve Linux support Improve Linux support Aug 22, 2022
@generic-pers0n generic-pers0n added the platforms An issue regarding platforms label Aug 22, 2022
@TheEvilSkeleton TheEvilSkeleton marked this pull request as ready for review August 22, 2022 15:44
Copy link
Member

@generic-pers0n generic-pers0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Saucedacity's .desktop file (io.github.saucedacity.Saucedacity.desktop.in), APP_ID is used instead of APP_NAME. I believe that you should use APP_NAME instead because based on what the Exec field appears to represent, the actual binary is supposed to be executed and the binary is still named 'saucedacity' from my testing on an Arch Linux machine. I tried launching the final .desktop file after building on Arch Linux and it didn't work, so I believe this is the cause.

Other than that very small thing, everything looks good!

Copy link
Member

@generic-pers0n generic-pers0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will be merging later.

@generic-pers0n generic-pers0n merged commit 1761238 into tenacityteam:main Aug 24, 2022
@TheEvilSkeleton TheEvilSkeleton deleted the linux branch August 24, 2022 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request platforms An issue regarding platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants