fix(request): correct SSE, retry, multipart, and HEAD handling - #137
Merged
Merged
Conversation
Decode SSE into NDJSON incrementally with LF, CRLF and CR framing, preserving UTF-8 across chunks and cancelling the response when output fails. Await writes to injected output streams. Make retry backoff respect the request deadline, preserve repeated multipart fields and files, and route HEAD output through the common writer so -o creates parent directories and does not also print headers to stdout.
mattsse
requested changes
Sep 8, 2026
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream SSE as NDJSON incrementally, handling split UTF-8 and LF/CRLF/CR framing. Cancel upstream reads when output fails and await writes to injected streams.
Make retry delays respect the request deadline, preserve repeated multipart fields and files, and route HEAD output consistently through
-o, including directory creation.Validation: 53 request tests passed, plus typechecks, lint, formatting and changelog validation.
AI-assisted