fix(request): preserve paid responses and recovery context - #136
Merged
Conversation
mattsse
previously requested changes
Sep 8, 2026
decofe
force-pushed
the
fix/mpp-payment-outcomes
branch
from
September 9, 2026 17:04
ca36711 to
5282433
Compare
Write headers and metadata from the final response, preserve HTTP error bodies through the selected output route, and report application failures as E_HTTP. Flush response output before exit and keep CLI diagnostics on stderr. Do not automatically replay credential-bearing requests or forward credentials across origins. Report uncertain payment or response-processing outcomes with safe available challenge, transaction or channel references, without exposing credentials or replacing final session errors with charge-fallback advice.
brendanjryan
force-pushed
the
fix/mpp-payment-outcomes
branch
from
September 9, 2026 17:31
5282433 to
9f77beb
Compare
brendanjryan
dismissed
mattsse’s stale review
September 9, 2026 17:34
Addressed by the unpaid and streaming response-body failure commits; full CI passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write headers and metadata from the final response, preserve HTTP error bodies through the requested output route, and report application failures as
E_HTTP. Flush output before exit and send CLI diagnostics to stderr.Avoid automatic replay of credential-bearing requests and forwarding credentials across origins. Report uncertain payment outcomes with available recovery references without exposing credentials.
Validation: 52 request tests passed, plus typechecks, lint, formatting and changelog validation.
AI-assisted