Repository navigation
Show custom search attribute values in the SAA table #3987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
laurakwhit
merged 4 commits into
main
from
laura/fe-1011-custom-sa-values-missing-in-saa-table
Oct 7, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a806734
fix(activities): show custom search attribute values in the activitie…
laurakwhit c1c352d
fix(nexus-operations, schedules): show custom search attribute values…
laurakwhit b202d72
refactor(search-attributes): move toSearchAttributes to decode-payloa…
laurakwhit 0a8cd98
Add null check for custom search attribute values
laurakwhit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <script lang="ts"> | ||
| import Timestamp from '$lib/components/timestamp.svelte'; | ||
| import Tooltip from '$lib/holocene/tooltip.svelte'; | ||
| import { Badge } from '$lib/io/badge'; | ||
| import { | ||
| SEARCH_ATTRIBUTE_TYPE, | ||
| type SearchAttributeType, | ||
| } from '$lib/types/workflows'; | ||
| import { | ||
| TRUNCATE_LENGTH, | ||
| truncateValue, | ||
| } from '$lib/utilities/truncate-value'; | ||
|
|
||
| type Props = { | ||
| value: unknown; | ||
| type?: SearchAttributeType; | ||
| truncate?: boolean; | ||
| }; | ||
|
|
||
| let { value, type, truncate = false }: Props = $props(); | ||
|
|
||
| const displayValue = $derived( | ||
| Array.isArray(value) ? value.join(', ') : String(value), | ||
| ); | ||
| const hideTooltip = $derived( | ||
| !truncate || truncateValue(displayValue).length <= TRUNCATE_LENGTH, | ||
| ); | ||
| </script> | ||
|
|
||
| {#if value != null} | ||
| {#if type === SEARCH_ATTRIBUTE_TYPE.DATETIME && typeof value === 'string'} | ||
| <Timestamp dateTime={value} /> | ||
| {:else if type === SEARCH_ATTRIBUTE_TYPE.BOOL} | ||
| <Badge text={displayValue} /> | ||
| {:else} | ||
| <Tooltip | ||
| usePortal | ||
| text={displayValue} | ||
| top | ||
| class="min-w-0" | ||
| hide={hideTooltip} | ||
| > | ||
| {truncate ? truncateValue(displayValue) : displayValue} | ||
| </Tooltip> | ||
| {/if} | ||
| {/if} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They share the wrapper of the table, but not the code that turns a row into cells. The custom search attribute support lived in the part that isn't shared.
The workflows list has a conversion layer that decodes search attributes along with the rest of each row. The standalone activities list used the API response directly and its table cell never had the custom search attribute logic like the workflows did.
Yup, updated in c1c352d.