Collapse common errors by default - #3921
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
This looks so much better! I wonder if Common Errors is a good title when there is errors/warnings/info. Maybe Helpful Hints? |
Member
|
@Alex-Tideman Agreed, so much better! Are there plans to make this customer-facing? How about "Diagnostics" for the title? It's more overarching because this panel includes a mix of info, warning, and error messages. I also wonder if it should take up the full width of the page? We have the room, so why not? It would give the content more breathing room. |
laurakwhit
commented
Sep 16, 2026
laurakwhit
marked this pull request as ready for review
September 17, 2026 20:47
bilal-karim
approved these changes
Sep 17, 2026
laurakwhit
force-pushed
the
laura/fe-420-collapse-common-errors-by-default
branch
from
September 17, 2026 21:56
7051d24 to
198ee35
Compare
laurakwhit
deleted the
laura/fe-420-collapse-common-errors-by-default
branch
September 17, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Renders the workflow common errors as a single card with collapsable accordions instead of a flat list of alerts.
max-h-64, with a bottom fade that appear only while there is more content below. A run with many findings no longer pushes the rest of the page down.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
FE-420Docs
Any docs updates needed?