Skip to content

Collapse common errors by default - #3921

Merged
laurakwhit merged 3 commits into
mainfrom
laura/fe-420-collapse-common-errors-by-default
Sep 17, 2026
Merged

laurakwhit merged 3 commits into
mainfrom
laura/fe-420-collapse-common-errors-by-default

Conversation

@laurakwhit

Copy link
Copy Markdown
Collaborator

Description & motivation 💭

Renders the workflow common errors as a single card with collapsable accordions instead of a flat list of alerts.

  • The header carries a per-severity count ("1 error, 2 warnings, 4 info") and the dismiss button.
  • Each error is an accordion with a severity-colored left border. The most severe one starts open while the rest collapse to a single line with a truncated description.
  • The list scrolls at max-h-64, with a bottom fade that appear only while there is more content below. A run with many findings no longer pushes the rest of the page down.
  • Findings sort by severity (error → warning → info).

Screenshots (if applicable) 📸

Before After
Screenshot 2026-09-14 at 2 51 12 PM Screenshot 2026-09-14 at 2 43 43 PM
Screenshot 2026-09-14 at 2 50 57 PM Screenshot 2026-09-14 at 2 43 59 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

FE-420

Docs

Any docs updates needed?

@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
holocene Ready Ready Preview Sep 17, 2026 9:57pm UTC

Request Review

@Alex-Tideman

Copy link
Copy Markdown
Collaborator

This looks so much better!

I wonder if Common Errors is a good title when there is errors/warnings/info. Maybe Helpful Hints?

@bilal-karim

Copy link
Copy Markdown
Member

@Alex-Tideman Agreed, so much better! Are there plans to make this customer-facing?

How about "Diagnostics" for the title? It's more overarching because this panel includes a mix of info, warning, and error messages.

I also wonder if it should take up the full width of the page? We have the room, so why not? It would give the content more breathing room.

Comment thread src/lib/components/common-errors/common-error-card.svelte
@laurakwhit
laurakwhit marked this pull request as ready for review September 17, 2026 20:47
@laurakwhit
laurakwhit requested a review from a team as a code owner September 17, 2026 20:47
@laurakwhit
laurakwhit force-pushed the laura/fe-420-collapse-common-errors-by-default branch from 7051d24 to 198ee35 Compare September 17, 2026 21:56
@laurakwhit
laurakwhit merged commit 80d864d into main Sep 17, 2026
17 checks passed
@laurakwhit
laurakwhit deleted the laura/fe-420-collapse-common-errors-by-default branch September 17, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants