Skip to content

refactor: migrate tests/admin_test.go to testcore.NewEnv pattern #9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaptersix merged 2 commits into from
Mar 26, 2026
+17 −32
Merged

refactor: migrate tests/admin_test.go to testcore.NewEnv pattern #9675

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
649af9d
refactor: migrate tests/admin_test.go to testcore.NewEnv pattern
chaptersix Mar 26, 2026
9ac9fe7
Merge branch 'main' into admin-test-env
chaptersix Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 17 additions & 32 deletions tests/admin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"time"

"github.com/google/uuid"
"github.com/stretchr/testify/suite"
commonpb "go.temporal.io/api/common/v1"
sdkclient "go.temporal.io/sdk/client"
"go.temporal.io/sdk/workflow"
Expand All @@ -19,39 +18,25 @@ import (
"go.temporal.io/server/tests/testcore"
)

type AdminTestSuite struct {
testcore.FunctionalTestBase
testContext context.Context
}

func TestAdminTestSuite(t *testing.T) {
t.Parallel()
suite.Run(t, new(AdminTestSuite))
}

func (s *AdminTestSuite) SetupSuite() {
// Call parent setup to initialize the test cluster
s.FunctionalTestBase.SetupSuite()
s.testContext = context.Background()
}

func (s *AdminTestSuite) TestAdminRebuildMutableState_ChasmDisabled() {
rebuildMutableStateWorkflowHelper(s, false)
}

func (s *AdminTestSuite) TestAdminRebuildMutableState_ChasmEnabled() {
cleanup := s.OverrideDynamicConfig(dynamicconfig.EnableChasm, true)
defer cleanup()

configValues := s.GetTestCluster().Host().DcClient().GetValue(dynamicconfig.EnableChasm.Key())
s.NotEmpty(configValues, "EnableChasm config should be set")
configValue, _ := configValues[0].Value.(bool)
s.True(configValue, "EnableChasm config should be true")
rebuildMutableStateWorkflowHelper(s, true)
t.Run("TestAdminRebuildMutableState_ChasmDisabled", func(t *testing.T) {
s := testcore.NewEnv(t, testcore.WithSdkWorker())
rebuildMutableStateWorkflowHelper(s, false)
})
t.Run("TestAdminRebuildMutableState_ChasmEnabled", func(t *testing.T) {
s := testcore.NewEnv(t, testcore.WithSdkWorker(), testcore.WithDynamicConfig(dynamicconfig.EnableChasm, true))

configValues := s.GetTestCluster().Host().DcClient().GetValue(dynamicconfig.EnableChasm.Key())
s.NotEmpty(configValues, "EnableChasm config should be set")
configValue, _ := configValues[0].Value.(bool)
s.True(configValue, "EnableChasm config should be true")
rebuildMutableStateWorkflowHelper(s, true)
})
}

// common test helper
func rebuildMutableStateWorkflowHelper(s *AdminTestSuite, testWithChasm bool) {
func rebuildMutableStateWorkflowHelper(s *testcore.TestEnv, testWithChasm bool) {
tv := testvars.New(s.T())
workflowFn := func(ctx workflow.Context) error {
var randomUUID string
Expand All @@ -70,13 +55,13 @@ func rebuildMutableStateWorkflowHelper(s *AdminTestSuite, testWithChasm bool) {
workflowID := tv.Any().String()
workflowOptions := sdkclient.StartWorkflowOptions{
ID: workflowID,
TaskQueue: s.TaskQueue(),
TaskQueue: s.WorkerTaskQueue(),
WorkflowRunTimeout: 20 * time.Second,
}
ctx, cancel := context.WithTimeout(s.testContext, 30*time.Second)
ctx, cancel := context.WithTimeout(s.Context(), 30*time.Second)
defer cancel()

workflowRun, err := s.SdkClient().ExecuteWorkflow(s.testContext, workflowOptions, workflowFn)
workflowRun, err := s.SdkClient().ExecuteWorkflow(s.Context(), workflowOptions, workflowFn)
s.NoError(err)
runID := workflowRun.GetRunID()

Expand Down
Loading