Migrate workflow_memo_test.go to TestEnv#9671
Open
chaptersix wants to merge 2 commits intotemporalio:mainfrom
Open
Migrate workflow_memo_test.go to TestEnv#9671chaptersix wants to merge 2 commits intotemporalio:mainfrom
chaptersix wants to merge 2 commits intotemporalio:mainfrom
Conversation
Replace legacy FunctionalTestBase + testify suite pattern with testcore.NewEnv(t) following the established migration pattern. - Remove WorkflowMemoTestSuite struct and suite.Run - Convert test methods to standalone functions with t.Run subtests - Replace old TaskPoller struct with s.TaskPoller().PollAndHandleWorkflowTask - Update handler signature to return RespondWorkflowTaskCompletedRequest - Remove debug Logger.Info calls and unused imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_memo_test.gofrom legacyFunctionalTestBase+ testify suite totestcore.NewEnv(t)patternTaskPollerstruct withs.TaskPoller().PollAndHandleWorkflowTaskTest plan
go test -tags "disable_grpc_modules,test_dep" -run TestWorkflowMemoTestSuite -count=1 -v ./tests/passes locally