Open
Conversation
stephanos
force-pushed
the
stephanos/buf-format
branch
from
e365bae to
c7fcb4a
Compare
stephanos
commented
Mar 25, 2026
| fmt-protos: $(BUF) | ||
| @printf $(COLOR) "Formatting proto files..." | ||
| @$(BUF) format -w $(PROTO_ROOT)/internal | ||
| @$(BUF) format -w --config chasm/lib/buf.yaml chasm/lib |
Contributor
Author
There was a problem hiding this comment.
(1) added new Makefile target
stephanos
commented
Mar 25, 2026
| @$(BUF) lint --config chasm/lib/buf.yaml $(CHASM_BINPB) | ||
|
|
||
| fmt: fmt-gofix fmt-imports fmt-yaml | ||
| fmt: fmt-gofix fmt-imports fmt-protos fmt-yaml |
Contributor
Author
There was a problem hiding this comment.
(2) included new Makefile target in fmt target
stephanos
commented
Mar 25, 2026
| cache: true | ||
|
|
||
| - name: format golang import statements | ||
| - name: apply formatters |
Contributor
Author
There was a problem hiding this comment.
(3) Renamed CI build step
stephanos
force-pushed
the
stephanos/buf-format
branch
from
c7fcb4a to
9dd7e76
Compare
stephanos
force-pushed
the
stephanos/buf-format
branch
from
9dd7e76 to
0e4d7c2
Compare
stephanos
force-pushed
the
stephanos/buf-format
branch
from
0e4d7c2 to
43506e2
Compare
yycptt
approved these changes
Mar 26, 2026
Comment on lines
3
to
-4
| package temporal.server.api.adminservice.v1; | ||
| option go_package = "go.temporal.io/server/api/adminservice/v1;adminservice"; |
Member
There was a problem hiding this comment.
I kinda like how they are grouped together before... but looks like that's not the standard...
Contributor
Author
There was a problem hiding this comment.
I briefly checked buf is doing the right thing here; and I found the official Google style guide that confirms it 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Adds
buf formatas a Makefile target; and integrates it intomake fmt.All
.protochanges are from runningmake fmt.Why?
Consistent protobuf file style.
How did you test it?