Nexus Standalone: Delete#9654
Open
stephanos wants to merge 1 commit intostephanos/nexus-standalone-cancelfrom
Open
Nexus Standalone: Delete#9654stephanos wants to merge 1 commit intostephanos/nexus-standalone-cancelfrom
stephanos wants to merge 1 commit intostephanos/nexus-standalone-cancelfrom
Conversation
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
6 times, most recently
from
ac37168 to
44cdbf9
Compare
stephanos
changed the base branch from
feature/nexus-standalone
to
stephanos/nexus-standalone-cancel
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
4 times, most recently
from
44193d9 to
bb2664f
Compare
stephanos
commented
Mar 26, 2026
| len(req.GetOperationId()), config.MaxIDLengthLimit()) | ||
| } | ||
| if len(req.GetRunId()) > config.MaxIDLengthLimit() { | ||
| return serviceerror.NewInvalidArgumentf("run_id exceeds length limit. Length=%d Limit=%d", |
Contributor
Author
There was a problem hiding this comment.
SAA is parsing the UUID which I thought wasn't necessary here as we don't do that anywhere else either AFAIK.
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
3 times, most recently
from
8c294e5 to
6ed485f
Compare
stephanos
force-pushed
the
stephanos/nexus-standalone-del
branch
from
6ed485f to
05f023d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How did you test it?
Can't verify functional tests yet due to missing impl.