Open
Conversation
yycptt
reviewed
Mar 25, 2026
Member
yycptt
left a comment
yycptt
left a comment
There was a problem hiding this comment.
- We need to use businessID instead of workflowID here, as chasm executions need this as well.
- CHASM provides separate ID space across archetypes, so the rate limiter key needs to be (nsID, businessID, archetypeID)
yycptt
reviewed
Mar 25, 2026
| return s.chasmRegistry | ||
| } | ||
|
|
||
| func (s *ContextImpl) GetWorkflowIDReuseRL(namespaceID namespace.ID, workflowID string) quotas.RateLimiter { |
Member
There was a problem hiding this comment.
I don't really have strong opinion but want to understand why the RLs cache is on shard level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Implement a rate limiter to limit workflow ID reuse.
Why?
Some patterns can create large number of worklow exeuction with same IThis can cause some issues in the persistence partition.
How did you test it?