Skip to content

Fix typo: overriden -> overridden in comments #9628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

Fix typo: overriden -> overridden in comments #9628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ type (
PProf struct {
// Port is the port on which the PProf will bind to
Port int `yaml:"port"`
// Host defaults to `localhost` but can be overriden
// Host defaults to `localhost` but can be overridden
// for instance in the case of dual stack IPv4/IPv6
Host string `yaml:"host"`
}
Expand Down
2 changes: 1 addition & 1 deletion common/persistence/sql/sqlplugin/mysql/session/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func buildDSNAttrs(dbKind sqlplugin.DbKind, cfg *config.SQL) (map[string]string,
attrs[isolationLevelAttrName] = defaultIsolationLevel
}

// these attrs are always overriden
// these attrs are always overridden
for k, v := range dsnAttrOverrides {
attrs[k] = v
}
Expand Down
4 changes: 2 additions & 2 deletions temporal/fx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,7 @@ type SpanExporterInputs struct {

// TraceExportModule holds process-global telemetry fx state defining the set of
// OTEL trace/span exporters used by tracing instrumentation. The following
// types can be overriden/augmented with fx.Replace/fx.Decorate:
// types can be overridden/augmented with fx.Replace/fx.Decorate:
//
// - []go.opentelemetry.io/otel/sdk/trace.SpanExporter
var TraceExportModule = fx.Options(
Expand Down Expand Up @@ -965,7 +965,7 @@ var TraceExportModule = fx.Options(
)

// ServiceTracingModule holds per-service (i.e. frontend/history/matching/worker) fx
// state. The following types can be overriden with fx.Replace/fx.Decorate:
// state. The following types can be overridden with fx.Replace/fx.Decorate:
//
// - []go.opentelemetry.io/otel/sdk/trace.BatchSpanProcessorOption
// default: empty slice
Expand Down
Loading