Nexus Standalone: Terminate + Cancel by stephanos · Pull Request #9624 · temporalio/temporal

stephanos · 2026-03-23T15:14:00Z

How did you test it?

Can't verify functional tests yet due to missing impl.

stephanos · 2026-03-23T21:28:28Z

chasm/lib/nexusoperation/validator.go

+			len(req.GetIdentity()), config.MaxIDLengthLimit())
+	}
+	return nil
+}


^ I considered re-using these by introducing an interface or two, but then again ... maybe that's overkill.

Overkill IMHO

stephanos · 2026-03-24T01:19:22Z

tests/nexus_standalone_test.go

+		s.Contains(err.Error(), "operation_id is required")
 	})
 }



^ will need to verify and maybe tweak tests once everything's implemented

bergundy

The only thing that's missing for me is request ID dedupe.

bergundy · 2026-03-24T03:06:03Z

chasm/lib/nexusoperation/handler.go

+	})
+
+	resp, _, err := chasm.UpdateComponent(ctx, ref, func(o *Operation, ctx chasm.MutableContext, req *nexusoperationpb.TerminateNexusOperationRequest) (*nexusoperationpb.TerminateNexusOperationResponse, error) {
+		_, err := o.Terminate(ctx, chasm.TerminateComponentRequest{


Missing a request ID here (not sure if this is already in the API but it should be.

bergundy · 2026-03-24T03:06:30Z

chasm/lib/nexusoperation/handler.go

+	})
+
+	resp, _, err := chasm.UpdateComponent(ctx, ref, func(o *Operation, ctx chasm.MutableContext, req *nexusoperationpb.RequestCancelNexusOperationRequest) (*nexusoperationpb.RequestCancelNexusOperationResponse, error) {
+		if err := o.Cancel(ctx, nil); err != nil {


Let's dedupe here based on a cancel request ID. See SAA for reference.

bergundy · 2026-03-24T03:07:15Z

chasm/lib/nexusoperation/validator.go

+			len(req.GetIdentity()), config.MaxIDLengthLimit())
+	}
+	return nil
+}


Overkill IMHO

bergundy · 2026-03-24T03:07:31Z

chasm/lib/nexusoperation/validator.go

+func validateRequestCancelNexusOperationExecutionRequest(req *workflowservice.RequestCancelNexusOperationExecutionRequest, config *Config) error {
+	if req.GetOperationId() == "" {
+		return serviceerror.NewInvalidArgument("operation_id is required")
+	}
+	if len(req.GetOperationId()) > config.MaxIDLengthLimit() {
+		return serviceerror.NewInvalidArgumentf("operation_id exceeds length limit. Length=%d Limit=%d",
+			len(req.GetOperationId()), config.MaxIDLengthLimit())
+	}
+	if len(req.GetRunId()) > config.MaxIDLengthLimit() {
+		return serviceerror.NewInvalidArgumentf("run_id exceeds length limit. Length=%d Limit=%d",
+			len(req.GetRunId()), config.MaxIDLengthLimit())
+	}
+	if len(req.GetIdentity()) > config.MaxIDLengthLimit() {
+		return serviceerror.NewInvalidArgumentf("identity exceeds length limit. Length=%d Limit=%d",
+			len(req.GetIdentity()), config.MaxIDLengthLimit())
+	}
+	return nil
+}
+
+func validateTerminateNexusOperationExecutionRequest(req *workflowservice.TerminateNexusOperationExecutionRequest, config *Config) error {
+	if req.GetOperationId() == "" {
+		return serviceerror.NewInvalidArgument("operation_id is required")
+	}
+	if len(req.GetOperationId()) > config.MaxIDLengthLimit() {
+		return serviceerror.NewInvalidArgumentf("operation_id exceeds length limit. Length=%d Limit=%d",
+			len(req.GetOperationId()), config.MaxIDLengthLimit())
+	}
+	if len(req.GetRunId()) > config.MaxIDLengthLimit() {
+		return serviceerror.NewInvalidArgumentf("run_id exceeds length limit. Length=%d Limit=%d",
+			len(req.GetRunId()), config.MaxIDLengthLimit())
+	}
+	if len(req.GetIdentity()) > config.MaxIDLengthLimit() {
+		return serviceerror.NewInvalidArgumentf("identity exceeds length limit. Length=%d Limit=%d",
+			len(req.GetIdentity()), config.MaxIDLengthLimit())
+	}
+	return nil
+}


We need a request ID on both of these and to validate it

stephanos · 2026-03-24T22:26:46Z

chasm/lib/nexusoperation/proto/v1/operation.proto

+
+  // The reason for requesting cancellation.
+  string reason = 10;
 }


^ mimicking ActivityCancelState

stephanos · 2026-03-24T23:04:44Z

chasm/lib/nexusoperation/validator.go

+			len(req.GetIdentity()), config.MaxIDLengthLimit())
+	}
+
+	// TODO: use different config for limit


As the comment says, I'll leave this here for now (mimics SAA) but we're investigating a better option

stephanos · 2026-03-24T23:05:09Z

chasm/lib/nexusoperation/operation_executors.go

Was failing tests after rebase

…ne-cancel

bergundy · 2026-03-25T00:31:22Z

chasm/lib/nexusoperation/proto/v1/operation.proto

+}
+
+message NexusOperationTerminateState {
+  string request_id = 1;


Please add a comment explaining what this is and how it is used.

bergundy · 2026-03-25T00:32:38Z

chasm/lib/nexusoperation/frontend.go

+	}
+
+	if req.GetRequestId() == "" {
+		// Since this mutates the request, we clone it first so that any retries use the original request.


Doesn't seem necessary and would be preferable if we used the same request ID for retries.

Also, can you say when this request would ever be retried from this location? I think I'm missing something.

Right; this is verbatim from SAA (I assumed what's there was reviewed and is a blessed pattern). I hadn't seen it before either ... 👀

I tracked this down and I believe this was an overcorrection on the SAA team; I've let them know.

bergundy · 2026-03-25T00:35:49Z

chasm/lib/nexusoperation/operation.go

+	}))
+}
+
+func (o *Operation) handleCancellationRequested(


Should this be called requestCancel for consistency with Terminate?

Also followed the SAA naming here; but I also like requestCancel 👍

bergundy · 2026-03-25T00:37:38Z

chasm/lib/nexusoperation/operation.go

+
+		return chasm.TerminateComponentResponse{}, nil
+	}
+


There's nothing transitioning to the terminated state here... You should also store the terminate reason somehow. I would look at SAA to figure out the best place to store it.

Right; that's why I have "unimplemented" there. I was under the impression that isn't available yet; ie blocked on the HSM to CHASM migration. Let me take a closer look again.

Talked offline; it's in scope here - added now.

bergundy · 2026-03-25T00:37:48Z

chasm/lib/nexusoperation/operation.go

+		return chasm.TerminateComponentResponse{}, nil
+	}
+
 	return chasm.TerminateComponentResponse{}, serviceerror.NewUnimplemented("not implemented")


Suggested change

return chasm.TerminateComponentResponse{}, serviceerror.NewUnimplemented("not implemented")

return chasm.TerminateComponentResponse{}, nil

Not quite as we'll need a transition - added now.

bergundy · 2026-03-25T00:38:16Z

chasm/lib/nexusoperation/operation.go

+	return o.handleCancellation(ctx, newCancellation(req))
+}
+
+func (o *Operation) handleCancellation(


Do we need this separate method?

Yes, unless we should duplicate the code since it's called from both Cancel and requestCancel?

stephanos · 2026-03-25T21:51:09Z

chasm/lib/nexusoperation/validator.go

+	} else if len(req.GetRequestId()) > config.MaxIDLengthLimit() {
+		return serviceerror.NewInvalidArgumentf("request_id exceeds length limit. Length=%d Limit=%d",
+			len(req.GetRequestId()), config.MaxIDLengthLimit())
+	}


Moved them all here from frontend; and to the top for easier scanning.

stephanos · 2026-03-25T21:52:24Z

chasm/lib/nexusoperation/proto/v1/operation.proto

  // Request ID used to deduplicate terminate requests.
  string request_id = 1;
+  // The identity of the client who requested termination.
+  string identity = 2;


Need this to store the identity, too. Even though there's no way to query it for the user (yet?).

stephanos changed the base branch from main to feature/nexus-standalone March 23, 2026 15:14

stephanos changed the title ~~Stephanos/nexus standalone cancel~~ Nexus Standalone: Terminate + Cancel Mar 23, 2026

stephanos force-pushed the stephanos/nexus-standalone-cancel branch 4 times, most recently from a69b3a4 to 3bc48be Compare March 23, 2026 21:16

stephanos commented Mar 23, 2026

View reviewed changes

stephanos force-pushed the stephanos/nexus-standalone-cancel branch 10 times, most recently from 5a99e83 to c7313a0 Compare March 24, 2026 01:18

stephanos commented Mar 24, 2026

View reviewed changes

stephanos marked this pull request as ready for review March 24, 2026 01:19

stephanos requested review from a team as code owners March 24, 2026 01:19

stephanos requested review from bergundy and gow March 24, 2026 01:19

stephanos force-pushed the stephanos/nexus-standalone-cancel branch from c7313a0 to d1b9216 Compare March 24, 2026 01:25

bergundy reviewed Mar 24, 2026

View reviewed changes

stephanos requested a review from a team as a code owner March 24, 2026 21:00

stephanos force-pushed the stephanos/nexus-standalone-cancel branch from f8c16bc to 49cb758 Compare March 24, 2026 21:11

stephanos requested a review from a team as a code owner March 24, 2026 21:11

stephanos added 2 commits March 24, 2026 14:16

Nexus Standalone: Terminate + Cancel

6bd13c9

validate request_id

3166061

stephanos force-pushed the stephanos/nexus-standalone-cancel branch 4 times, most recently from 1b50884 to c4dcd26 Compare March 24, 2026 21:40

handle cancel/terminate req

db6cfb6

stephanos force-pushed the stephanos/nexus-standalone-cancel branch from c4dcd26 to db6cfb6 Compare March 24, 2026 21:41

fmt

fd1b5bf

stephanos commented Mar 24, 2026

View reviewed changes

stephanos force-pushed the stephanos/nexus-standalone-cancel branch from bbd18bd to 47463a8 Compare March 24, 2026 22:51

simplify NexusOperationTerminateState

9639961

stephanos force-pushed the stephanos/nexus-standalone-cancel branch from 47463a8 to 9639961 Compare March 24, 2026 23:02

stephanos commented Mar 24, 2026

View reviewed changes

chasm/lib/nexusoperation/operation_executors.go

Copy link

Contributor Author

stephanos Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was failing tests after rebase

stephanos added 3 commits March 24, 2026 16:09

Merge branch 'feature/nexus-standalone' into stephanos/nexus-standalo…

c61f898

…ne-cancel

drop this

2ec647d

disable test

77b50b9

stephanos requested a review from bergundy March 25, 2026 00:12

bergundy reviewed Mar 25, 2026

View reviewed changes

stephanos added 5 commits March 25, 2026 11:36

requestCancel

d710d0c

request_id comment

3b67d36

request_id comment

7b54b66

request_id

63a5d54

outcome

808f1f6

stephanos force-pushed the stephanos/nexus-standalone-cancel branch from baa41d7 to 808f1f6 Compare March 25, 2026 20:57

stephanos commented Mar 25, 2026

View reviewed changes

clearer test

65847d9

stephanos force-pushed the stephanos/nexus-standalone-cancel branch from adf30e8 to 65847d9 Compare March 25, 2026 22:11

check request_id

1b5a6b1

stephanos requested a review from bergundy March 25, 2026 22:15

	return chasm.TerminateComponentResponse{}, serviceerror.NewUnimplemented("not implemented")
	return chasm.TerminateComponentResponse{}, nil

Conversation

stephanos commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How did you test it?

Uh oh!

stephanos Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bergundy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephanos Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephanos Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephanos Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stephanos commented Mar 23, 2026 •

edited

Loading

stephanos Mar 23, 2026 •

edited

Loading

stephanos Mar 25, 2026 •

edited

Loading

stephanos Mar 25, 2026 •

edited

Loading

stephanos Mar 25, 2026 •

edited

Loading