fix: avoid zero-rate queue reader throttling#9619
Open
mykaul wants to merge 1 commit intotemporalio:mainfrom
Open
fix: avoid zero-rate queue reader throttling#9619mykaul wants to merge 1 commit intotemporalio:mainfrom
mykaul wants to merge 1 commit intotemporalio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persistenceMaxQPSis set to0(meaning "unlimited"), the queue reader rate limiter receives a zero rate, causing all queue readers to fail with "burst size is smaller than required token count" and never process tasks.returnafter the error log to prevent falling through to an invalid lock/read path.Bug Details
NewHostRateLimiterRateFncomputesfloat64(persistenceMaxRPS()) * persistenceMaxRPSRatio. WhenpersistenceMaxRPS()returns 0 (unlimited), this produces rate=0, which creates a rate limiter with burst=0. The reader then cannot acquire even 1 token, logging the error but continuing intor.Lock()without tasks — effectively a tight error loop.Testing
persistenceMaxQPS: 0in dynamic config.