Conversation
stephanos
force-pushed
the
tweak-gofix-retry
branch
3 times, most recently
from
0592337 to
9f6a6b1
Compare
| exit 1 | ||
| fi | ||
|
|
||
| lint-yaml: |
There was a problem hiding this comment.
make fmt already invokes make fmt-yaml
| - name: format golang import statements | ||
| run: | | ||
| make fmt-imports | ||
| make fmt |
There was a problem hiding this comment.
Includes make fmt-gofix and make fmt-yaml, too, now.
stephanos
force-pushed
the
tweak-gofix-retry
branch
from
9f6a6b1 to
da3b399
Compare
Makefile
Outdated
| fmt-gofix: | ||
| @printf $(COLOR) "Run go fix..." | ||
| @while ! go fix -any -rangeint ./...; do \ | ||
| @while true; do \ |
There was a problem hiding this comment.
do we need to filter out generated files like other lint checks do?
There was a problem hiding this comment.
should we have a max iteration check here?
There was a problem hiding this comment.
do we need to filter out generated files like other lint checks do?
👍 it seems it does this automatically; will add a comment
On success, it silently updates your source files. It discards any fix that touches generated files since the appropriate fix in that case is to the logic of the generator itself.
should we have a max iteration check here?
👍 I figured the GH action has a timeout, but it's good to do this explicitly
stephanos
force-pushed
the
tweak-gofix-retry
branch
from
2ce1442 to
333d3df
Compare
stephanos
force-pushed
the
tweak-gofix-retry
branch
from
72bdfa9 to
21ce2f2
Compare
2 participants
What changed?
fmt-gofixto retry based on output log.fmt-gofixin CI.How did you test it?