Open
Conversation
chris-olszewski
force-pushed
the
olszewski/fix_hidden_steep_issues
branch
from
640cdb4 to
db522b8
Compare
chris-olszewski
force-pushed
the
olszewski/fix_hidden_steep_issues
branch
from
db522b8 to
c8237bb
Compare
chris-olszewski
force-pushed
the
olszewski/fix_hidden_steep_issues
branch
from
c8237bb to
156ec3f
Compare
chris-olszewski
commented
Apr 10, 2026
| class Worker | ||
| class PollerBehavior | ||
| def _to_bridge_options: -> untyped | ||
| end |
Member
Author
There was a problem hiding this comment.
Not super easy to tell from the diff, but we want these to be nested e.g. Worker::PollerBehavior::SimpleMaximum, which they are in the Ruby file, but not in RBS
| check 'lib' | ||
| ignore 'lib/temporalio/api', 'lib/temporalio/internal/bridge/api' | ||
| library 'uri', 'objspace' | ||
| library 'uri', 'objspace', 'etc' |
Member
Author
There was a problem hiding this comment.
Required for Etc.nprocessors usage in thread_pool.rb
| connection:, | ||
| namespace:, | ||
| data_converter: DataConverter.default, | ||
| data_converter: Converters::DataConverter.default, |
Member
Author
There was a problem hiding this comment.
This was flat out broken, but most calls go through Client.connect instead of this directly
| @@ -158,15 +158,15 @@ def start_update_with_start_workflow(input) | |||
| # @!visibility private | |||
| def signal_with_start_workflow(input) | |||
Member
Author
There was a problem hiding this comment.
There were 2 bugs in this implementation:
- It used
input.workflowwhich doesn't exist - It passed
inputinto_with_started_panfor header forwarding which would also cause a crash sinceheadersdon't exist on the input type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Fix a few existing type check errors that were hidden from the protobuf hole.
Anything that wasn't just filling in RBS mistakes will have an additional comment.
Why?
I encountered these when enabling parts of the codebase to get checked with Steep in #414
I split these out to a new PR as these changes get lost in that PR with 40k lines of generated RBS files.
Checklist
Closes N/A
How was this tested:
Steep now passes, for behavior changes I added regression tests.
Any docs updates needed?
N/A