Introduce local timeout for activity heartbeats#2804
Open
Sushisource wants to merge 1 commit intotemporalio:masterfrom
Open
Introduce local timeout for activity heartbeats#2804Sushisource wants to merge 1 commit intotemporalio:masterfrom
Sushisource wants to merge 1 commit intotemporalio:masterfrom
Conversation
Sushisource
commented
Mar 12, 2026
| private static final long DEFAULT_LOCAL_HEARTBEAT_TIMEOUT_BUFFER_MILLIS = 5000; | ||
|
|
||
| static long getLocalHeartbeatTimeoutBufferMillis() { | ||
| String envVal = System.getenv("TEMPORAL_ACTIVITY_TIMEOUT_DELAY"); |
Member
Author
There was a problem hiding this comment.
I did this b/c I didn't want a worker option for a setting I expect basically no one will ever care about adjusting. If we feel otherwise, can promote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
See title
Why?
User request, matches Core behavior (though only for heartbeat timeouts, not overall activity timeouts)
Checklist
Closes Keep track of current heartbeat timeout while retrying failures in doHeartBeatLocked #2775
How was this tested:
Added test
Any docs updates needed?