Pass AllowNoPollers flag to SetCurrentVersion and SetRampingVersion #2067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Pass AllowNoPollers flag to SetCurrentVersion and SetRampingVersion
Why?
So that Go SDK users can take advantage of the new option implemented in v1.29 of the server
Checklist
Closes
How was this tested:
Integration test
Any docs updates needed?
Note
Adds an AllowNoPollers option to worker deployment client ops and passes it through to server requests, with new tests and a dev server version bump.
AllowNoPollers
toWorkerDeploymentSetCurrentVersionOptions
andWorkerDeploymentSetRampingVersionOptions
.AllowNoPollers
inSetWorkerDeploymentCurrentVersionRequest
andSetWorkerDeploymentRampingVersionRequest
.TestRampVersion_AllowNoPollers
andTestCurrentVersion_AllowNoPollers
to validate behavior when no pollers exist.internal/cmd/build/main.go
tov1.5.0-rc
.Written by Cursor Bugbot for commit 96e4296. This will update automatically on new commits. Configure here.