Skip to content

Conversation

carlydf
Copy link
Contributor

@carlydf carlydf commented Oct 2, 2025

What was changed

Pass AllowNoPollers flag to SetCurrentVersion and SetRampingVersion

Why?

So that Go SDK users can take advantage of the new option implemented in v1.29 of the server

Checklist

  1. Closes

  2. How was this tested:
    Integration test

  3. Any docs updates needed?


Note

Adds an AllowNoPollers option to worker deployment client ops and passes it through to server requests, with new tests and a dev server version bump.

  • Worker Deployment Client:
    • Add AllowNoPollers to WorkerDeploymentSetCurrentVersionOptions and WorkerDeploymentSetRampingVersionOptions.
    • Pass AllowNoPollers in SetWorkerDeploymentCurrentVersionRequest and SetWorkerDeploymentRampingVersionRequest.
  • Tests:
    • Add TestRampVersion_AllowNoPollers and TestCurrentVersion_AllowNoPollers to validate behavior when no pollers exist.
  • Dev tooling:
    • Bump dev server cached version in internal/cmd/build/main.go to v1.5.0-rc.

Written by Cursor Bugbot for commit 96e4296. This will update automatically on new commits. Configure here.

@carlydf carlydf requested a review from a team as a code owner October 2, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants