Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restruct sentry proj #79

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

restruct sentry proj #79

wants to merge 4 commits into from

Conversation

bkodes
Copy link

@bkodes bkodes commented Jul 24, 2023

The code in /sentry currently does not run.

Cannot access http.client.IncompleteRead.__mro_entries__ from inside a workflow. If this is code from a module not used in a workflow or known to only be us
ed deterministically from a workflow, mark the import as pass through.

Separating the workflow code into its own file resolves the issue

What was changed

Moved greetings workflow to workflows.py and import workflow within worker

Why?

So others can reference this sample and have no issue running it without alterations being made

Checklist

  1. Closes

  2. How was this tested:

Followed run instructions in README.md. Outputs:

cmd: poetry run python starter.py
output: Workflow result: Hello, World!
  1. Any docs updates needed?

No

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Moving workflows to a separate file is definitely a good thing these days. Just need to get that activity back in there and I think we'll be good.

sentry/workflows.py Show resolved Hide resolved
@bkodes bkodes requested a review from cretz July 24, 2023 20:25
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you run poe lint before pushing (poe format will fix the formatting issues)

sentry/workflows.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should update the starter.py to reference the workflow from this file and not through the worker.py file

sentry/worker.py Outdated Show resolved Hide resolved
bkodes and others added 2 commits July 24, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants