Skip to content

Use workflow init from samples#143

Open
drewhoskins-temporal wants to merge 4 commits into
mainfrom
drewhoskins_workflow_init
Open

Use workflow init from samples#143
drewhoskins-temporal wants to merge 4 commits into
mainfrom
drewhoskins_workflow_init

Conversation

@drewhoskins-temporal

Copy link
Copy Markdown
Contributor

What was changed

Workflow Init is a brand new feature.
Let's show people best practices for each sample that uses a signal or update handler and receives workflow arguments.

Why?

These changes make sure these workflows are initialized before signal or update handlers are run.

Checklist

  1. Closes

  2. How was this tested:

Automated:
poetry run pytest workflow_test.py
Manual:
Follow instructions in
bedrock/entity/README.md
and
message_passing/safe_message_handlers/README.md

  1. Any docs updates needed?

Comment thread pyproject.toml
[tool.poetry.dependencies]
python = "^3.8"
temporalio = "^1.7.0"
temporalio = { path = "../sdk-python" }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot be committed now. Needs to await the released Python SDK having Workflow Init support.

@cretz cretz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, holding approval until tagged release of SDK is made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants