Setting busybox repository and tag via values.yaml #659
+13
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I've updated the helmchart such that the busybox repository and tag are set via values set in values.yaml
Why?
When working in isolated networks, having this image always set to
busybox:latest
as it is currently will cause the cluster to always try and check for what the latest version is, causing an ImagePullBackoff error.Similarly, I've needed to pull this image from a custom registry rather than the public one, too, so having the public repo hard-coded is inconvenient.
It's easy enough to patch yourself, but I thought other users in similar situations would appreciate not needing to do so.
If values.yaml needs to be backwards compatible, please let me know and I'd be happy to work out how to make this set the image to busybox:latest if there is no definition for Values.busybox!
Checklist
Closes N/A
How was this tested:
I ran the cluster locally using values.yaml and checked that all pods were healthy.
Any docs updates needed?
I don't believe so, but please correct me if I am wrong!