Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting busybox repository and tag via values.yaml #659

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FathomlessFunction
Copy link

@FathomlessFunction FathomlessFunction commented Mar 6, 2025

What was changed

I've updated the helmchart such that the busybox repository and tag are set via values set in values.yaml

Why?

When working in isolated networks, having this image always set to busybox:latest as it is currently will cause the cluster to always try and check for what the latest version is, causing an ImagePullBackoff error.
Similarly, I've needed to pull this image from a custom registry rather than the public one, too, so having the public repo hard-coded is inconvenient.

It's easy enough to patch yourself, but I thought other users in similar situations would appreciate not needing to do so.

If values.yaml needs to be backwards compatible, please let me know and I'd be happy to work out how to make this set the image to busybox:latest if there is no definition for Values.busybox!

Checklist

  1. Closes N/A

  2. How was this tested:
    I ran the cluster locally using values.yaml and checked that all pods were healthy.

  3. Any docs updates needed?
    I don't believe so, but please correct me if I am wrong!

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants