Modernize GitHub links pinned to commit SHAs - #5012
Draft
Duncanma wants to merge 1 commit into
Draft
Conversation
Unpin links without line anchors to the repo's default branch (main/master), fixing two that had moved to new paths along the way. Re-verify and re-pin links with line anchors to the current default-branch commit, correcting line numbers where the referenced code has moved.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| [Cloud Samples in Go](https://github.com/temporalio/cloud-samples-go/blob/1dd4254b6ed1937e361005c0144410e72b8a5542/client/api/apikey.go). | ||
| [Cloud Samples in Go](https://github.com/temporalio/cloud-samples-go/blob/main/client/api/client.go). | ||
|
|
||
| ### Terraform Provider |
Contributor
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Temporal.Headings] 'Terraform Provider' should use sentence-style capitalization.
Contributor
❌ Docs build failedWe couldn't automatically identify the specific error from the build output. Here are the last 60 lines of the build log: Build log tailRun |
Contributor
📖 Docs PR preview links
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to an earlier GitHub link sweep that intentionally skipped ~40 links pinned to commit SHAs, since many carry line anchors (
#L108) that drift and would silently point at the wrong line if just moved tomain.main, ormasterforgrpc/grpc). Two of these had moved to a new path along the way, so the link target was updated accordingly:cloud-samples-go'sclient/api/apikey.gowas merged intoclient/api/client.go.ui'sserver/docker/config-template.yamlmoved toserver/config/docker.yaml.temporal's history size/count limit defaults moved fromservice/history/configs/config.gointocommon/dynamicconfig/constants.go, andcommon/metrics/defs.go→metric_defs.go.One item is flagged rather than fixed:
limits.mdxlinks toMaxCHASMCallbacksPerWorkflow, a dynamic config key that has been removed entirely fromtemporalio/temporal(it was marked temporary pending CHASM's rollout). Left aTODOcomment for whoever owns that content to decide whether to drop the bullet or replace it.Test plan
vale --config .vale-ci.ini docs/on all touched files — 0 errors/warnings (pre-existing heading-style suggestions only, unrelated to this change)docs/outside the one flagged item┆Attachments: EDU-6866 Modernize GitHub links pinned to commit SHAs