-
Notifications
You must be signed in to change notification settings - Fork 250
EDU-4084: Update observability.mdx #3415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Ping @fairlydurable ... we hit this issue in production and would like to make sure others see this caveat before repeating the same mishap. 🙏 |
Hi @joe-dakota! Unfortunately the personnel who can perform technical reviews this week are at Replay. Do you have access to any Temporal engineers who can vet this? |
Thank you for submitting this PR. This issue appears to apply to all SDKs, not just Golang. My current wording: |
Alas, I don't have access to Temporal engineers. I wasn't quite sure if it applied to golang, or all SDKs. Makes sense that it is applicable to all. Thanks for the update! |
Noting that workflow.UpsertTypedSearchAttributes creates NDE
What does this PR do?
This pull request includes a crucial update to the
docs/develop/go/observability.mdx
file, adding guidance on handling nondeterminism errors when upserting search attributes in existing workflows.Notes to reviewers
docs/develop/go/observability.mdx
: Added a code example and explanation on using versioning to prevent failures caused by nondeterminism errors when upserting search attributes in existing workflows.