Repository navigation
EDU-3824: Add best practice advice to Typescript Versioning - #3303
fairlydurable wants to merge 21 commits into
Conversation
Source of truth: Grant Smith
|
After experimenting more in my local, I see that I'm missing something. I'll circle back when i'm more solid |
|
Okay yeah I have a pretty good grasp of what's going on now -- at least in the python SDK. I'll need to revise the writuep and test in other SDKs, but I made a little youtube series deep diving into it. we can maybe put that in the docs too 👍 |
|
Yep, I looked into TS and Dotnet as well. Here's the writeup. I'll work on getting it to a point that can be merged etc |
|
|
||
| #### Overview | ||
|
|
||
| The following sample shows how the `patched()` function behaves, providing explanations at each stage of the patching flow: |
There was a problem hiding this comment.
Can we add a line about defining the version conditions in descending order?
There was a problem hiding this comment.
Something like
The best practice is to write your version conditionals in descending order so that newly executed workflows will set their marker as the latest version.
The default value for the version is
""(empty string)
|
@GSmithApps Status check on this one? Thanks! |
Applying changes to python/versioning.mdx
Updating typescript/versioning.mdx with versioning changes.
brianmacdonald-temporal
left a comment
There was a problem hiding this comment.
This is a tricky concept, and a difficult one to explain. This is a great draft that addresses the concept well. I kept the structure, but made some changes made to wording to make it read more smoothly. Please review and let me know if you have any questions.
|
Erica Sadun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Moving to PR 3577 to make the CLA Assistant happy |
Source of truth/Author: Grant Smith
Moving to PR 3577 to make the CLA Assistant happy