add temporal worker deployment create-version#971
add temporal worker deployment create-version#971jaypipes wants to merge 1 commit intotemporalio:serverlessfrom
temporal worker deployment create-version#971Conversation
|
|
| cc.ScalingGroups = map[string]*computeConfigScalingGroup{ | ||
| // NOTE(jaypipes): No option but to hard-code the string "main" for | ||
| // the scaling group name. | ||
| "main": { | ||
| Provider: &computeProvider{ | ||
| // NOTE(jaypipes): No option but to hard-code the string | ||
| // "awslambda" for the provider type. | ||
| Type: "awslambda", | ||
| Details: providerDetails, | ||
| }, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
I think the hard coding is fine, just a nit to please call it "default" as that is what we have taken up in other places
Adds implementation of the `temporal worker deployment create-version` CLI command using only direct gRPC API calls, not the sdk-go client code. TODO: add unit tests. Signed-off-by: Jay Pipes <jay.pipes@temporal.io>
jaypipes
force-pushed
the
jaypipes/serverless
branch
from
4dded90 to
765f4f8
Compare
| var cc *computeConfig | ||
| if c.AwsLambdaInvoke != "" { | ||
| providerDetails := map[string]any{ | ||
| "invoke": c.AwsLambdaInvoke, |
There was a problem hiding this comment.
| "invoke": c.AwsLambdaInvoke, | |
| "arn": c.AwsLambdaInvoke, |
| option-sets: | ||
| - deployment-version | ||
| options: | ||
| - name: aws-lambda-invoke |
There was a problem hiding this comment.
how do I set the role ARN and external ID for this?
| - name: scaler-min-instances | ||
| type: int | ||
| description: | | ||
| Minimum number of server-owned Workers a Worker Deployment should | ||
| ensure are polling on task queue targets. | ||
| default: -1 | ||
| - name: scaler-max-instances | ||
| type: int | ||
| description: | | ||
| Maximum number of server-owned Workers a Worker Deployment should | ||
| allow to poll on task queue targets. A setting of 0 means no limit. | ||
| default: -1 |
There was a problem hiding this comment.
these are not real scaler settings. https://github.com/temporalio/temporal-auto-scaled-workers/blob/main/wci/workflow/scaling_algorithm/no_sync_match.go#L16 has the settings (and their default values)
There was a problem hiding this comment.
@02strich that isn't applicable to the open source server.
| cc.ScalingGroups = map[string]*computeConfigScalingGroup{ | ||
| // NOTE(jaypipes): No option but to hard-code the string "main" for | ||
| // the scaling group name. | ||
| "main": { | ||
| Provider: &computeProvider{ | ||
| // NOTE(jaypipes): No option but to hard-code the string | ||
| // "awslambda" for the provider type. | ||
| Type: "awslambda", | ||
| Details: providerDetails, | ||
| }, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
I think the hard coding is fine, just a nit to please call it "default" as that is what we have taken up in other places
|
|
||
| var cc *computeConfig | ||
| if c.AwsLambdaInvoke != "" { | ||
| providerDetails := map[string]any{ |
3 participants
Adds implementation of the
temporal worker deployment create-versionCLI command using only direct gRPC API calls, not the sdk-go client code.TODO: add unit tests.