Fix Tembo icon for Claude MCP connectors - #380
Merged
Merged
Conversation
Co-authored-by: Ry <4283+ryw@users.noreply.github.com>
Co-authored-by: Ry <4283+ryw@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes Claude MCP connector branding by ensuring Tembo Agent Studio advertises a display name + icon via MCP serverInfo, and by making favicon assets reachable without an authenticated TAS session (plus updating docs/changelogs to reflect the Claude Desktop setup).
Changes:
- Update the middleware matcher to avoid redirecting unauthenticated requests for
/favicons/*branding assets. - Advertise
title,icons, andwebsiteUrlin the MCP server initialization response. - Regenerate and update documentation/changelogs to document Claude Web + Desktop connector setup and the branding fix.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| web/src/proxy.ts | Adjusts middleware matching to prevent session redirects for public favicon branding assets. |
| web/src/lib/mcp/server.ts | Adds MCP serverInfo metadata (display name, icon URL, website URL) built from the public origin. |
| web/src/lib/mcp/server.test.ts | Adds coverage asserting the MCP server advertises the new branding fields. |
| web/src/lib/docs-content.ts | Regenerates in-app docs bundle to reflect updated MCP docs and changelog entries. |
| docs/src/content/docs/mcp.md | Documents that Claude Web and Desktop share the same custom connector configuration. |
| docs/src/content/docs/changelog.md | Adds an Unreleased “Fixed” entry describing the connector branding fix. |
| CHANGELOG.md | Mirrors the changelog update in the repo-root changelog. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+58
to
62
| // session when rendering serverInfo.icons, so those assets must never hit | ||
| // the sign-in redirect. (API routes resolve workspaces themselves.) | ||
| matcher: [ | ||
| "/((?!api|_next/static|_next/image|favicon.ico|robots.txt|sitemap.xml).*)", | ||
| "/((?!api|_next/static|_next/image|favicons|favicon.ico|robots.txt|sitemap.xml).*)", | ||
| ], |
Comment on lines
+101
to
+116
| it("advertises the TAS display name and public icon", async () => { | ||
| const client = await connectedClient(); | ||
| expect(client.getServerVersion()).toEqual({ | ||
| name: "tembo-agent-studio", | ||
| title: "Tembo Agent Studio", | ||
| version: "1.0.0", | ||
| icons: [ | ||
| { | ||
| src: "https://tas.example.com/favicons/default-tembo.png?v=3", | ||
| mimeType: "image/png", | ||
| sizes: ["256x256"], | ||
| }, | ||
| ], | ||
| websiteUrl: "https://tas.example.com", | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serverInfo/favicon.icoas a fallbackRoot cause
Claude could not retrieve TAS branding from the deployed origin:
/favicons/default-tembo.svgredirected unauthenticated requests to sign-in,/favicon.icoreturned 404, and the MCP initialize response did not includeserverInfo.icons. Claude consequently fell back to the Railway deployment icon.Verification
pnpm test— 34 files, 232 tests passedpnpm exec next typegen && pnpm exec tsc --noEmitpnpm lint— no errors; three pre-existing warningspnpm buildinweb/pnpm buildindocs/200 image/pngand200 image/x-iconresponses with byte-for-byte matching assets