Put Rust and pgrx tests in separate modules #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since they compile separately, different dependencies can lead to warnings (see pgcentralfoundation/pgrx#1774 for details). So move shared functions to a new `test_util` module, keep the Rust-only tests in `mod test`, and keep the pgrx tests in `mod tests`. I wish I could put the pgrx tests in the required `pg_test` schema, but it appears that they require that the module be named "tests". Thanks @eeeebbbbrrrr for suggesting this solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since they compile separately, different dependencies can lead to warnings (see pgcentralfoundation/pgrx#1774 for details). So move shared functions to a new
test_utilmodule, keep the Rust-only tests inmod test, and keep the pgrx tests inmod tests. I wish I could put the pgrx tests in the requiredpg_testschema, but it appears that they require that the module be named "tests".Thanks @eeeebbbbrrrr for suggesting this solution.