Subst plugin for upstream #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop all jit exectuion machinery in favour of just swaping wasms in place
Start detecting setcodes to contracts we are substing to fix the case where subst metadata was wrong is we deployed a contract with same hash multiple times Move substitution registry to initialization hook to fix replay case
Remove old diff file
…max-transaction-time option value
…set on re-subst detected
…fter changing subst conf and restart
…c access sepcifically
…ary vm field from wasm iface, probably left from 5.0 change i didnt have in 4.0.4 splugin
guilledk
force-pushed
the
subst_plugin_for_upstream
branch
from
f7ac196 to
ebf7a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal
nodeoschanges:This are changes that I had to make outside
plugins/in order to make substitution functionality work.libraries/chain/controller.cpp: Add optionalpost_db_initstd::functionbased hook, this is needed in order to enable substitution before replay, but after intial db setup, might need to consider a way to allow multiple plugins to register a hook?libraries/chain/include/eosio/chain/controller.hpp: Makemutable_dba public method, need to get a nonconstref to the mainchainbase::databasein order to perform subsitutions.libraries/chain/include/eosio/chain/types.hpp: Add customsubst_meta_typeto internalnodeosdb types to store our metadata.libraries/chain/include/eosio/chain/wasm_interface.hpp: Ugly change, need to make thewasm_interface_implpointer public in order to clear code caches after updating a substitution.libraries/libfc/include/fc/network/http/http_client.hpp&libraries/libfc/src/network/http/http_client.cpp: Add httpGETmethods.plugins/CMakeLists.txt: Add subst_plugin and subst_plugin_api build.programs/nodeos/CMakeLists.txt: Addsubst_plugin&subst_plugin_apitonodeoslink step.