Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/log when feature table error #2432

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Task/log when feature table error #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fd3d776
log error about feature table when is in error
AlvaroVega Oct 25, 2024
2a2bbfa
log more about commitFeatures warn
AlvaroVega Oct 25, 2024
8268d3d
log arcgisPersistenceBackend size
AlvaroVega Oct 28, 2024
a76671f
fix logger
AlvaroVega Oct 28, 2024
99d8495
Update CHANGES_NEXT_RELEASE
AlvaroVega Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES_NEXT_RELEASE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- [cygnus-ngsi][arcgis] Log feature table error
- [cygnus-ngsi][arcgis] fix log warn to debug level in arcgis feature when no object id is found (#2430)
2 changes: 1 addition & 1 deletion ...src/main/java/com/telefonica/iot/cygnus/backends/arcgis/restutils/ArcgisFeatureTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ private void commitFeatures(final List<Feature> featureList, int action) {
+ featureList.size());
}
} else {
LOGGER.error("WARN - Argis.commitFeatures called with 0 entities.");
LOGGER.error("WARN - Argis.commitFeatures called with " + sizeList + " entities and hasError() " + hasError());
}

} else {
Expand Down
3 changes: 3 additions & 0 deletions cygnus-ngsi/src/main/java/com/telefonica/iot/cygnus/sinks/NGSIArcgisFeatureTableSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ protected int featuresBatched() {
*/
protected ArcgisFeatureTable getPersistenceBackend(String featureServiceUrl) throws CygnusRuntimeError {

LOGGER.debug("Current persistenceBackend has " + arcgisPersistenceBackend.size() +" tables ");

if (arcgisPersistenceBackend.containsKey(featureServiceUrl) &&
arcgisPersistenceBackend.get(featureServiceUrl).connected() ){
LOGGER.info("Using persistenceBackend which contains key for Feature table: " + featureServiceUrl);
Expand Down Expand Up @@ -394,6 +396,7 @@ public void persistAggregation(NGSIArcgisAggregator aggregator) throws CygnusRun

featureTable.addToBatch(aggregation.getFeature());
if (featureTable.hasError()){
LOGGER.error("feature table " + featureTableUrl + " has error code " + featureTable.getErrorCode() + " with desc " + featureTable.getErrorDesc());
throw new ArcgisException(featureTable.getErrorCode(), featureTable.getErrorDesc());
}
}
Expand Down
Loading