Add sync config for Tekton Pruner documentation#696
Add sync config for Tekton Pruner documentation#696tekton-robot merged 2 commits intotektoncd:mainfrom
Conversation
|
/hold |
|
/unhold |
83251ea to
319acd3
Compare
319acd3 to
d0a5b4b
Compare
f4ad634 to
6e91481
Compare
vdemeester
left a comment
There was a problem hiding this comment.
Can you squash your commits ? Also, do we need the image in this PR ?
Generally images should be loaded from the project repo, i.e. tektoncd/pruner, rather than adding them directly in the website repo. |
@vdemeester @AlanGreene I tried that approach, it seems Hugo doesn't serve files from content/ at URL paths. |
c6f50d9 to
5ceea23
Compare
5ceea23 to
bbf4a65
Compare
708d59e to
6d7d163
Compare
|
@AlanGreene are we good to go now ? 👼🏼 |
|
I don't think so. Looking at the preview: https://deploy-preview-696--tekton.netlify.app/docs/pruner/
The image isn't loading. |
|
The page URL is: Since it's a relative URL, it's attempting to load the image from https://deploy-preview-696--tekton.netlify.app/docs/pruner/docs/images/pruner_functional_abstract.png which is incorrect. You will need to change the URL used to load the image to That's why I suggested moving the repo into the docs folder in the repo: #696 (comment) See for example the Dashboard readme referencing an image in the docs folder: https://github.com/tektoncd/dashboard/blob/6e54039d61e7b6de46efb56e61d3039b8091acb5/docs/README.md?plain=1#L22 |
|
/test |
6d7d163 to
fef5b9b
Compare
@AlanGreene I respect that suggestion, it is not that I didn't want to do that. But the problem was that I pushed the earlier changes before the pruner repo was modified with that image.and hence the build was not updated later, I just did a dummy push to retrigger that build and it is working fine. |
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
fef5b9b to
bea0cec
Compare
AlanGreene
left a comment
There was a problem hiding this comment.
Confirmed the image is loading as expected both in the website preview and in the pruner repo directly. Looks good 👍
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |





Changes
This PR adds
sync/config/pruner.yamlto sync documentation from tektoncd/pruner to the website.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.