Skip to content

Conversation

@khrm
Copy link
Contributor

@khrm khrm commented Jul 22, 2024

No description provided.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind tep

@tekton-robot tekton-robot added kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024
@khrm khrm force-pushed the retentionResult branch from ad39efd to 6e7ed59 Compare July 22, 2024 11:10
@khrm
Copy link
Contributor Author

khrm commented Jul 22, 2024

/test pull-community-teps-lint

@tekton-robot
Copy link
Contributor

@khrm: No presubmit jobs available for tektoncd/community@main

In response to this:

/test pull-community-teps-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm khrm force-pushed the retentionResult branch from 6e7ed59 to 4795a2a Compare July 22, 2024 11:24
@khrm
Copy link
Contributor Author

khrm commented Jul 24, 2024

/assign @avinal @enarha @sayan-biswas

@khrm
Copy link
Contributor Author

khrm commented Jul 24, 2024

/assign @vdemeester

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2024
@amir-badar
Copy link

amir-badar commented May 16, 2025

@khrm I wanna know if the retention policy under TektonResults component is configurable via TektonConfig CR? Like this

result:
    disabled: false
    is_external_db: false
    options:
      configMaps:
        config-results-retention-policy:
          data:
            runAt: "5 5 * * 0"
            maxRetention: "15"

This RedHat openshift doc here says that we can set maxRetention field this way.

@khrm khrm force-pushed the retentionResult branch from 4795a2a to bc01874 Compare August 13, 2025 10:45
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2025
@khrm khrm force-pushed the retentionResult branch from 0f60d40 to cfb364e Compare August 27, 2025 18:42
@khrm
Copy link
Contributor Author

khrm commented Aug 27, 2025

@amir-badar Yes, it's configurable using that, but we are changing maxRetention to defautlRetention. maxRetention will still work, but it's deprecated.

@khrm khrm force-pushed the retentionResult branch from cfb364e to e6879d8 Compare August 28, 2025 11:31
@enarha
Copy link

enarha commented Aug 28, 2025

One thing I find missing is how the deletion of logs happens. The TEP explains how data is deleted from the DB, please add a short description how that's connected to the logs deletion.
The rest is LGTM.

@khrm
Copy link
Contributor Author

khrm commented Sep 4, 2025

@enarha Sure. I would add that part also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants