[WIP] Separate symbology and labels from od

[cymed]

General

• Fix a bug
• Add a feature
• Maintenance / sustainability
• Add Documentation

Describe your changes

Concept of #409, but including symbology.

The PR introduces

• a table tww_od.tww_symbology_quarantine
• a table tww_od.tww_reach_point_labels
• a table tww_od.tww_wastewater_structure_labels
• a table tww_od.tww_wastewater_node_symbology
• a view tww_app.vw_tww_wastewater_node to include the now separated symbology columns. TODO: currently, moving the vw_tww_wastewater_node moves the corresponding reaches/reach points as well. Is this behaviour desired?

Changes on symbology are now stored in a separate table, which in turn leads to fewer circular triggers.
The symbology triggers now only add the wastewater structure/wastewater node OID to tww_od.tww_symbology_quarantine. After an INSERT, a statement level trigger updates symbology and labels

To-Do

When altering a geometry in tww_app.vw_tww_wastewater_node, the geometry of the reaches/reach points linked to it are updated too. We need feedback from the user group if this behaviour is desired or not.

Screenshots

Issue ticket number and link

Checklist before requesting a review

• I have performed a self-review of my code
• If it is a core feature, I have added thorough tests.
• CI Tests are green
• The documentation is up to date with the proposed change.
• My work is ready for review

Checklist before merge

• A review has been performed
• Comments are resolved
• Documentation is ready

[cymed]

I am struggling with the tests: As the label triggers are now deferred, we need to commit the transaction before testing labels and symbologies. When exactly should I commit and will committing impact the other tests?

[sjib]

@cymed could you describe how the new _status (integer) attribute should work?

What is the reason to remove the attributes tww_active and tww_local_extension?

[cymed]

@cymed could you describe how the new _status (integer) attribute should work?

_status is not new, it already exists on wastewater_node

What is the reason to remove the attributes tww_active and tww_local_extension?

They were in the code twice, I removed one entity