Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat typescript/str split #68

Merged
merged 20 commits into from
Oct 18, 2022

Conversation

nblfikr
Copy link
Contributor

@nblfikr nblfikr commented Oct 10, 2022

  • Programming langugage: Typescript

  • Function(s) that I'm implementing: str_split

  • Issue number: Typescript Implementation #18

  • I have created unit tests to support my implementation

  • I have created in-code documentation (or docstring) to document my code

  • (Optional) I have updated the README.md file to document the function I'm implementing

ini hasil testnya
image

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (aa053a6) compared to base (7c9e378).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            master       #68    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           50        12    -38     
  Lines          646        96   -550     
  Branches         6        11     +5     
==========================================
- Hits           646        96   -550     
Flag Coverage Δ
clojure ?
csharp 100.00% <100.00%> (ø)
go ?
rust ?
typescript 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
csharp/Pehape/String/Md5.cs 100.00% <100.00%> (ø)
typescript/src/string/lcfirst.ts 100.00% <100.00%> (ø)
typescript/src/string/str_split.ts 100.00% <100.00%> (ø)
go/str_split.go
go/strrpos.go
spec/pehape/string/strrev_spec.rb
go/implode.go
go/r_trim.go
go/trim.go
spec/pehape/string/hex2bin_spec.rb
... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldy505 aldy505 requested a review from elianiva October 11, 2022 00:51
typescript/src/string/str_split.ts Outdated Show resolved Hide resolved
typescript/src/string/str_split.ts Outdated Show resolved Hide resolved
typescript/src/string/str_split.ts Outdated Show resolved Hide resolved
typescript/src/string/str_split.ts Outdated Show resolved Hide resolved
@aldy505
Copy link
Member

aldy505 commented Oct 17, 2022

jalanin pnpm run lint:fix

@nblfikr
Copy link
Contributor Author

nblfikr commented Oct 17, 2022

sudah mas @aldy505

@aldy505 aldy505 requested a review from elianiva October 17, 2022 05:59
@elianiva elianiva merged commit fbb660c into teknologi-umum:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants